[Perf] Windows/x64: 2 Regressions on 8/17/2024 7:43:54 PM #106710

Activity

1. performanceautofiler

   added

   arch-x64

   os-windows

   runtime-coreclrspecific to the CoreCLR runtimespecific to the CoreCLR runtime

   untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

   on Aug 20, 2024
2. DrewScoggins

   transferred this issue fromdotnet/perf-autofiling-issueson Aug 20, 2024
3. ghost added

   area-System.Text.Json

   on Aug 20, 2024
4. DrewScoggins commented on Aug 20, 2024

   

   DrewScoggins

   on Aug 20, 2024

   Member

   More actions

   Related to #106503
5. DrewScoggins

   added

   tenet-performancePerformance related issuePerformance related issue

   tenet-performance-benchmarksIssue from performance benchmarkIssue from performance benchmark

   on Aug 20, 2024
6. dotnet-policy-service commented on Aug 20, 2024

   

   dotnet-policy-servicebot

   on Aug 20, 2024 – with Dotnet Policy Service

   Contributor

   More actions

   Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
   See info in area-owners.md if you want to be subscribed.
7. DrewScoggins commented on Aug 20, 2024

   

   DrewScoggins

   on Aug 20, 2024

   Member

   More actions

   PTAL @etemi
8. etemi commented on Aug 20, 2024

   

   etemi

   on Aug 20, 2024

   Contributor

   More actions

   TBH I don't (yet) see how this regression is related to my changes.
   I will try to reproduce this locally.
9. etemi commented on Aug 21, 2024

   

   etemi

   on Aug 21, 2024

   Contributor

   More actions

   • Regression for System.Text.Json.Document.Tests.Perf_EnumerateObject.PropertyIndexer(TestCase: StringProperties) seems to be caused by other changes

   • Regression for System.Text.Json.Document.Tests.Perf_EnumerateObject.PropertyIndexer(TestCase: NumericProperties) seems to be caused by my changes.
     Unfortunately I wasn't able to reproduce it locally. @eiriktsarpalis Could you please take a look too?
10. jeffhandley

    added this to the 9.0.0 milestone on Aug 23, 2024
11. jeffhandley

    removed

    untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

    on Aug 23, 2024
12. eiriktsarpalis commented on Aug 27, 2024

    

    eiriktsarpalis

    on Aug 27, 2024

    Last edited by eiriktsarpalis

    Member

    More actions

    I find it unlikely that this is being caused by #106503. It adds a few instructions to the main JsonDocument parsing method that could, theoretically, incur regressions in the micro level however the benchmark itself measures enumeration of a pre-parsed document which exercises a completely disjoint code-path.

    The regression concerns main, so I'm updating the milestone to reflect this.

    👍React with 👍1Reacted by etemi
13. eiriktsarpalis

    modified the milestones: 9.0.0, 10.0.0 on Aug 27, 2024
14. jeffhandley

    closed this as completedon Jul 16, 2025
15. github-actions

    locked and limited conversation to collaborators on Aug 15, 2025