Skip to content

Reject single line comments containing non-standard new line characers within Utf8JsonReader #27850

Closed
dotnet/corefx
#38036

Description

@ahsonkhan

In particular, throw as invalid JSON if a single line comment contains U+2028 / U+2029 (i.e. Line separator, Paragraph separator) anywhere within it which JSON5 treats as valid line terminator sequences.

A single line comments ends on either carriage return, line feed, or both (\r\n). We do not support any other line terminator sequence.

This constraint does not apply to multi-line comments which only end with */.

cc @GrabYourPitchforks

Activity

  1. self-assigned this
    on May 23, 2019
  2. transferred this issue fromdotnet/corefxon Jan 31, 2020
  3. added this to the 3.0 milestone on Jan 31, 2020
  4. ghost locked as resolved and limited conversation to collaborators on Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-System.Text.JsonenhancementProduct code improvement that does NOT require public API changes/additionstenet-reliabilityReliability/stability related issue (stress, load problems, etc.)

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions