Skip to content

Improve multi-segment Utf8JsonReader test coverage for ReadOnlySequence #27949

Closed
Closed
Improve multi-segment Utf8JsonReader test coverage for ReadOnlySequence#27949
Labels
area-System.Text.Jsonbacklog-cleanup-candidateAn inactive issue that has been marked for automated closure.help wanted[up-for-grabs] Good issue for external contributorsincrease-code-coverageTracking need to add more test and increase code coverage of a componenttest-enhancementImprovements of test source code
Milestone
Future

Description

@ahsonkhan
ahsonkhan
opened on Nov 19, 2018

In particular:

  • Add more tests for various sequence segment sizes with invalid JSON.
  • Add tests with valid comments that can be skipped or allowed.

Borrow the tests for the span-based Utf8JsonReader as a starting point.

Multi-segment support added here: dotnet/corefx#33462

Activity

  1. msftgits
    transferred this issue fromdotnet/corefxon Jan 31, 2020
  2. msftgits
    added this to the Future milestone on Jan 31, 2020

  3. marcusturewicz commented on Apr 7, 2020

    @marcusturewicz
    marcusturewicz
    on Apr 7, 2020
    Contributor

    I'd like to take this one. What sequence sizes should I use? And could you elaborate on the second point about comments?

  4. eiriktsarpalis
    added
    no-recent-activity
    on Oct 15, 2021

  6. GSPP commented on Oct 21, 2021

    @GSPP
    GSPP
    on Oct 21, 2021

    @eiriktsarpalis found another one from this series of issues.

  7. ghost removed
    no-recent-activity
    on Oct 21, 2021

  8. eiriktsarpalis commented on Oct 21, 2021

    @eiriktsarpalis
    eiriktsarpalis
    on Oct 21, 2021
    Member

    I'd be inclined to close this as a duplicate of #30706 and #30751, since they define more actionable test cases to be incorporated.

  9. eiriktsarpalis
    closed this as completedon Oct 21, 2021
  10. ghost locked as resolved and limited conversation to collaborators on Nov 20, 2021
  11. eiriktsarpalis
    added
    backlog-cleanup-candidateAn inactive issue that has been marked for automated closure.
    on Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-System.Text.Jsonbacklog-cleanup-candidateAn inactive issue that has been marked for automated closure.help wanted[up-for-grabs] Good issue for external contributorsincrease-code-coverageTracking need to add more test and increase code coverage of a componenttest-enhancementImprovements of test source code

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions