Skip to content

Run PAL tests in CI #34776

Description

@am11

We used to run PAL tests on every PR, somehow this got broken in the past and it is not clean to me when.

Originally posted by @janvorli in #34710


Other notes:

  • PAL tests build is currently failing on macOS. fixed by Fix PAL test build on non-Linux Unix platforms #35218.
  • Given PAL tests are useful for new platforms bring up, where msbuild/dotnet(1) is not available; we should consider:
    • adding an option in src/coreclr/build-runtime.sh to build PAL tests OR
    • move PAL tests under src/coreclr/tests and add option in src/coreclr/build-tests.sh to skip everything that depends on msbuild/dotnet(1), and build only PAL tests.

Activity

  1. guesshe commented on Apr 9, 2020

    @guesshe

    When I notice this issue, I set CLR_CMAKE_BUILD_TESTS in my CMake toolchain file. For each sub-project, I am currently maintain a toolchain file. I found it is flexible for me to do something in the toolchain file instead of modifying CMakeList.txt file that belongs to the folder.

  2. am11 commented on Apr 9, 2020

    @am11
    MemberAuthor

    You can simply run:

    ./src/coreclr/build-runtime.sh -skipgenerateversion -nopgooptimize \
        -cmakeargs -DCLR_CMAKE_BUILD_TESTS=1

    without modifying any file. But adding formal option in the script for PAL tests would be good (internally which can transform to the above).

  3. danmoseley commented on Apr 23, 2020

    @danmoseley
    Contributor

    Cc @janvorli fyi

  4. removed
    untriagedNew issue has not been triaged by the area owner
    on May 4, 2020
  5. added this to the 6.0.0 milestone on Jul 17, 2020
  6. self-assigned this
    on Sep 9, 2020
  7. linked a pull request that will close this issueRun PAL tests in CI #42049on Sep 10, 2020
  8. ghost locked as resolved and limited conversation to collaborators on Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions