Skip to content

Diagnostics.DiagnosticSource dependency on System.Memory on Full Framework #429

Closed as not planned
Closed as not planned
Diagnostics.DiagnosticSource dependency on System.Memory on Full Framework#429
Labels
area-System.Diagnostics.TracingenhancementProduct code improvement that does NOT require public API changes/additions
Milestone
Future

Description

@rzontar
rzontar
opened on Dec 2, 2019

The package System.Diagnostics.DiagnosticSource in version 4.6 has a dependency on System.Memory in the net45 and net46 builds. This was introduced by using Span<> and ReadOnlySpan<> in dotnet/corefx#37395.

Since the package is commonly used in profiling frameworks like:

My question is weather this is intended and we should accept the additional packages pulled in by System.Memory or could there be an alternative implementation on full framework? I also don't know if there is an performance benefit of the current implementation which would justify the dependency.

Activity

  1. Dotnet-GitSync-Bot
    added
    untriagedNew issue has not been triaged by the area owner
    on Dec 2, 2019

  2. Wraith2 commented on Dec 2, 2019

    @Wraith2
    Wraith2
    on Dec 2, 2019
    Contributor

    it can introduce a quite complex dependency graph especially for Asp.Net applications.

    Can you expand on that? what do you see happen?

  3. rzontar commented on Dec 2, 2019

    @rzontar
    rzontar
    on Dec 2, 2019
    Author

    Installing the current version of System.Diagnostics.DiagnosticSource produces the following entries in packages.config:

    <packages>
  <package id="System.Buffers" version="4.4.0" targetFramework="net471" />
  <package id="System.Diagnostics.DiagnosticSource" version="4.6.0" targetFramework="net471" />
  <package id="System.Memory" version="4.5.3" targetFramework="net471" />
  <package id="System.Numerics.Vectors" version="4.4.0" targetFramework="net471" />
  <package id="System.Runtime.CompilerServices.Unsafe" version="4.5.2" targetFramework="net471" />
</packages>

    This are 4 additional packages which could all require binding redirects if used in different projects across an application. We currently have binding redirects for System.Diagnostics.DiagnosticSource in place, since the above mentioned packages depend on different versions.

  4. jkotas
    added
    area-System.Diagnostics.Tracing
    on Dec 2, 2019
  5. tommcdon
    removed
    untriagedNew issue has not been triaged by the area owner
    on May 11, 2020
  6. tommcdon
    added this to the 5.0 milestone on May 11, 2020
  7. tommcdon
    modified the milestones: 5.0.0, 6.0.0 on Jul 30, 2020
  8. josalem
    added
    enhancementProduct code improvement that does NOT require public API changes/additions
    on Nov 7, 2020
  9. tommcdon
    modified the milestones: 6.0.0, 7.0.0 on Jun 16, 2021
  10. tommcdon
    modified the milestones: 7.0.0, Future on Jun 21, 2022
  11. radical
    added a commit that references this issue on Jul 7, 2022

    Add new commands for android: install, run and uninstall (dotnet#429)

    e40e075
  12. jkotas
    closed this as not plannedon Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-System.Diagnostics.TracingenhancementProduct code improvement that does NOT require public API changes/additions

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions