Repository navigation
QuicListener AcceptConnectionAsync and OperationCanceledException #78096
Description
The QuicListener can throw OperationCanceledException when the internal TLS handshake timeout expires, this is unexpected and not documented behavior.
See
It would be better to wrap the OperationCanceled exception from the internal timeout in a QuicException with the ConnectionTimeout error code
You should consider fixing this along #75184
Activity
ManickaP commentedon Nov 10, 2022
Triage: we should fix this, seems easy enough and should be addressed in 8.0.
rzikm commentedon May 29, 2023
@ManickaP I see in the code that this scenario should throw
QuicExceptionwithQuicError.ConnectionTimeout. I think we can close this issue now.ManickaP commentedon May 30, 2023
Depends where we decide to go with the exceptions. I left this open on purpose so we can discuss this.
In some cases, it looks we're deciding to go the way of different exception types, e.g. throwing
SocketExceptionfor IP related errors. But here we're doingQuicExceptionfor a timeout. So I think that the exception type here is still something we should include in the whole "exception discussion".karelz commentedon Jul 18, 2023
@wfurt this should also be addressed by your exception changes, shouldn't it?
wfurt commentedon Jul 18, 2023
no, we did not touch this one AFAIK. We should investigate separately and write some tests.
ManickaP commentedon Jul 18, 2023
We're throwing
QuicExceptionwithQuicError.ConnectionTimeoutas Radek wrote in #78096 (comment)I'm calling this done.