Skip to content

Regression on INTEL machines with TechEmpower Fortunes #86113

Closed

Description

@sebastienros

image

Only INTEL, both windows and linux. All Fortunes middleware (not platform).

Minimum set of commits: a442971...ab98c9b

Activity

  1. ghost added
    needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners
    on May 11, 2023
  2. ghost added
    untriagedNew issue has not been triaged by the area owner
    on May 11, 2023
  3. sebastienros commented on May 11, 2023

    @sebastienros
    MemberAuthor
  4. MihaZupan commented on May 11, 2023

    @MihaZupan
    Member

    From #84184 (comment)

    Tried the following commits:

    1. 1b56e96 (PR Improve IndexOfAnyValues throughput for needles with 0 #84184)
    2. e241509 (commit just before nr. 3)
    3. 58a1365 (PR Unroll StringBuilder.Append for const string #85894)
    load 1 2 3
    Requests/sec 304,458 302,716 -0.57% 281,044 -7.69%
    Requests 4,585,264 4,570,922 -0.31% 4,243,602 -7.45%
    Bad responses 0 0 0
  5. sebastienros commented on May 11, 2023

    @sebastienros
    MemberAuthor

    Thanks @MihaZupan, that's very helpful.

  6. sebastienros commented on May 11, 2023

    @sebastienros
    MemberAuthor

    @EgorBo confirmed this would also be fixed by #85551

  7. MihaZupan commented on May 11, 2023

    @MihaZupan
    Member

    Since I already had the runtime built, here are the numbers from aspnet-perf-win to further confirm #85894 (comment):

    load 2-perf 3-perf
    Requests/sec 208,299 204,782 -1.69%
    Requests 3,145,265 3,092,240 -1.69%
    Bad responses 0 0
  8. added
    area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
    on May 15, 2023
  9. added this to the 8.0.0 milestone on May 16, 2023
  10. ghost removed
    untriagedNew issue has not been triaged by the area owner
    on May 16, 2023
  11. removed
    needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners
    on May 16, 2023
  12. EgorBo commented on Jun 9, 2023

    @EgorBo
    Member

    Fixed via #85551 + improved by Dynamic PGO:

    image

  13. ghost locked as resolved and limited conversation to collaborators on Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMItenet-performancePerformance related issue

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions