Skip to content

DefaultMeterFactory.Create and MeterOptions.Scope #86684

Closed
Closed
DefaultMeterFactory.Create and MeterOptions.Scope#86684
Assignees
tarekgh
Labels
area-System.Diagnostics.Metric
Milestone
8.0.0

Description

@JamesNK
JamesNK
opened on May 24, 2023

Description

A meter factory sets the scope of the meter it creates to itself:

runtime/src/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/DefaultMeterFactory.cs

Lines 50 to 51 in ce689d9

Meter m = new Meter(options.Name, options.Version, options.Tags, scope: this);
meterList.Add(m);

However, a scope can be provided on MeterOptions.Scope, which passed to Create.

Create should probably throw an error if a scope is specified. Otherwise there could be confusion about why the specified scope value wasn't used.

Reproduction Steps

object myCoolScope = new object();
IMeterFactory f = CreateFactory();
Meter meter = f.Create(new MeterOptions("Name") { Scope = myCoolScope });

Debug.Assert(meter.Scope == myCoolScope); // Fails?!?!

Expected behavior

Throw an error.

Actual behavior

The scope provided by the user is ignored, and the meter scope is set to the factory.

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Activity

  1. ghost added
    needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners
    on May 24, 2023
  2. ghost added
    untriagedNew issue has not been triaged by the area owner
    on May 24, 2023
  3. JamesNK
    added
    area-System.Diagnostics.Metric
    and removed
    needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners
    on May 24, 2023

  4. JamesNK commented on May 24, 2023

    @JamesNK
    JamesNK
    on May 24, 2023
    MemberAuthor

    cc @tarekgh @noahfalk

  5. tarekgh
    added this to the 8.0.0 milestone on May 24, 2023
  6. ghost removed
    untriagedNew issue has not been triaged by the area owner
    on May 24, 2023
  7. tarekgh
    self-assigned this
    on May 24, 2023

  8. tarekgh commented on May 24, 2023

    @tarekgh
    tarekgh
    on May 24, 2023
    Member

    Thanks @JamesNK. I'll take care with that.

  9. tarekgh commented on May 26, 2023

    @tarekgh
    tarekgh
    on May 26, 2023
    Member

    This is addressed by #86740

  10. tarekgh
    closed this as completedon May 26, 2023
  11. ghost locked as resolved and limited conversation to collaborators on Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-System.Diagnostics.Metric

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions