Skip to content

be consistent about tests for WatchOS #92601

Closed
#117653
Closed
be consistent about tests for WatchOS#92601
#117653
Assignees
kotlarmilosdavidnguyen-tech
Labels
area-Infrastructure-monoin-prThere is an active PR which will close this issue when it is mergedos-tvosApple tvOS
Milestone
10.0.0

Description

@danmoseley
danmoseley
opened on Sep 25, 2023

Some places where we test for tvOS, we test for watchOS also (OperatingSystem.IsTvOS() || OperatingSystem.IsWatchOS(); ) ; some we do not. I'm guessing we should either consistently test for watchOS, or nowhere, or it's not useful/hard to reason about.

We have no "os-watchos" label so perhaps we should pull it everywhere?

#92570 (comment)

Activity

  1. danmoseley
    added
    area-Infrastructure-mono
    os-tvosApple tvOS
    on Sep 25, 2023
  2. ghost added
    untriagedNew issue has not been triaged by the area owner
    on Sep 25, 2023

  4. danmoseley commented on Sep 25, 2023

    @danmoseley
    danmoseley
    on Sep 25, 2023
    ContributorAuthor

    incidentally, in the linked issue, it's assumed the Odbc even works on tvOS/watchOS and I'm not sure whether that's true.

  5. steveisok
    removed
    untriagedNew issue has not been triaged by the area owner
    on Sep 26, 2023
  6. steveisok
    added this to the 9.0.0 milestone on Sep 26, 2023
  7. vitek-karas
    modified the milestones: 9.0.0, 10.0.0 on Jul 24, 2024

  8. kotlarmilos commented on Jul 14, 2025

    @kotlarmilos
    kotlarmilos
    on Jul 14, 2025
    Member

    Let's remove OperatingSystem.IsWatchOS() and close this issue.

  9. kotlarmilos
    assigned
    kotlarmilos
    and
    davidnguyen-tech
    on Jul 14, 2025
  10. dotnet-policy-service
    added
    in-prThere is an active PR which will close this issue when it is merged
    on Jul 15, 2025

  11. davidnguyen-tech commented on Jul 15, 2025

    @davidnguyen-tech
    davidnguyen-tech
    on Jul 15, 2025
    Member

    Hi, if we consistently don't check for WatchOS, shouldn't be also remove support for WatchOS builds?

  12. davidnguyen-tech
    closed this as completedin #117653on Jul 18, 2025
  13. github-actions
    locked and limited conversation to collaborators on Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-Infrastructure-monoin-prThere is an active PR which will close this issue when it is mergedos-tvosApple tvOS

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions