Skip to content

Fix CPU usage tests on mobile platforms - #105722

Merged
tarekgh merged 3 commits into
dotnet:mainfrom
tarekgh:FixCpuUsageTestsOnMobilePlatforms
Jul 30, 2024
Merged

Fix CPU usage tests on mobile platforms#105722
tarekgh merged 3 commits into
dotnet:mainfrom
tarekgh:FixCpuUsageTestsOnMobilePlatforms

Conversation

@tarekgh

@tarekgh tarekgh commented Jul 30, 2024

Copy link
Copy Markdown
Member

Fixes #105322

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 30, 2024
@azure-pipelines

azure-pipelines Bot commented Jul 30, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines

azure-pipelines Bot commented Jul 30, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@tarekgh

tarekgh commented Jul 30, 2024

Copy link
Copy Markdown
Member Author

/azp run runtime-androidemulator

@azure-pipelines

azure-pipelines Bot commented Jul 30, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines

azure-pipelines Bot commented Jul 30, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@tarekgh

tarekgh commented Jul 30, 2024

Copy link
Copy Markdown
Member Author

/azp run runtime-ioslikesimulator,runtime-maccatalyst

@azure-pipelines

azure-pipelines Bot commented Jul 30, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@tarekgh

tarekgh commented Jul 30, 2024

Copy link
Copy Markdown
Member Author

@matouskozak do you know why the runtime-ioslikesimulator legs get cancelled that fast?

@tarekgh tarekgh added area-System.Runtime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 30, 2024
@tarekgh tarekgh added this to the 9.0.0 milestone Jul 30, 2024
@dotnet-policy-service

dotnet-policy-service Bot commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

ericstj
ericstj approved these changes Jul 30, 2024
View reviewed changes

@ericstj ericstj left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Do we need to run additional pipelines to test this? -- n/m I see you did 👍

@tarekgh
tarekgh merged commit 9653506 into dotnet:main Jul 30, 2024
@matouskozak

matouskozak commented Jul 31, 2024

Copy link
Copy Markdown
Member

@matouskozak do you know why the runtime-ioslikesimulator legs get cancelled that fast?

Sorry, didn't manage to check it in time. Looks like the simulator legs ran eventually and the System.Runtime.Extansions.Tests didn't fail, so everything should be good. I'll check the rolling builds and notify here if we encounter more issue.

@tarekgh
tarekgh deleted the FixCpuUsageTestsOnMobilePlatforms branch August 6, 2024 20:03
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ericstj ericstj ericstj approved these changes
+1 more reviewer
@carlossanlop carlossanlop carlossanlop left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@tarekgh tarekgh

Labels

area-System.Runtime

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

[Apple] New Environment.CpuUsage tests failing on Apple mobile

4 participants

@tarekgh @matouskozak @carlossanlop @ericstj