[cdac] Add helper methods to Target for reading UTF-8/16 strings - #106483
Merged
Merged
Conversation
elinor-fung
requested review from
AaronRobinsonMSFT,
davidwrighton and
lambdageek
August 15, 2024 17:18
ghost
added
the
needs-area-label
elinor-fung
added
area-Diagnostics-coreclr
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @tommcdon |
This was referenced Aug 16, 2024
Closed
Closed
AaronRobinsonMSFT
approved these changes
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #106358 (comment)
Add
ReadUtf8StringandReadUtf16StringtoTarget. ForReadUtf16String, it reads in target endianness, but does not specify target endianness in its name - I think this is consistent with all the otherRead*functions onTargetwhich read in target endianness.I did not add a
ReadUTF16MetadataString/ReadUtf16StringMetadataEndiannessin this change, since with the switch to synthesize a ecma-335 image and just use MetadataReader, I don't think we have a current use case.