[release/9.0-staging] Allow nested types inside of the <Module> type#111479
Closed
davidwrighton wants to merge 1 commit into
Closed
[release/9.0-staging] Allow nested types inside of the <Module> type#111479davidwrighton wants to merge 1 commit into
davidwrighton wants to merge 1 commit into
Conversation
- This isn't disallowed by spec, although ilasm and ildasm cannot handle these cases - Simply skip adding the type to the available class hash. Backport of bugfix portion of PR dotnet#111435 Fixes dotnet#111164 in .NET 9
ghost
added
the
kg
approved these changes
Jan 16, 2025
jkotas
approved these changes
Jan 16, 2025
jeffschwMSFT
approved these changes
Jan 16, 2025
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
lgtm. we will take for consideration in 9.0.x
jeffschwMSFT
added
the
Servicing-consider
Member
|
Decision was that, if the impact is limited to obfuscated code, this doesn't meet the servicing bar without more evidence of widespread impact. We can come back to this if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #111435 to release/9.0-staging
/cc @davidwrighton
Customer Impact
This was reported by @4nonym0us as a regression in .NET 9 which causes some .NET obfuscators to generate faulty code with .NET 9. I do not know which obfuscators, or how prevalent this pattern is. The impact is that assemblies obfuscated by these tools will fail to load on .NET 9. An analysis of the ECMA specification indicates that this particular approach is permitted by ECMA 335 although it certainly wasn't anticipated by any of our tooling.
Regression
This was introduced with the work to improve the performance of assembly loading in scenarios where many nested types exist. See PR #94825
Testing
Manual testing of a repro scenario provided by @4nonym0us. It is not possible to use ilasm to add a regression test to our system, as it is unable to represent this form of metadata. To do so would require adding new functionality to ilasm, and probably ildasm to enable new syntax that would allow for types nested in the
<module>class.Risk
Low , fix is effectively a check that just skips doing the problematic operation.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.
Backport of bugfix portion of PR #111435
Fixes #111164 in .NET 9