Skip to content

Fix linux build image in eng/pipelines/libraries/stress/http.yml#111664

Merged
rzikm merged 6 commits into
mainfrom
akoeplinger-patch-2
Jan 27, 2025
Merged

Fix linux build image in eng/pipelines/libraries/stress/http.yml#111664
rzikm merged 6 commits into
mainfrom
akoeplinger-patch-2

Conversation

@akoeplinger

Copy link
Copy Markdown
Member

@rzikm This fixes the disk space issue. It still fails to build with this error in the "Build HttpStress" step, do you have an idea:

Invalid interpolation format for "client" option in service "services": "${DOCKERFILE:-Dockerfile}"

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@rzikm

rzikm commented Jan 22, 2025

Copy link
Copy Markdown
Member

Hi, I don't know, we are using the same image for SslStress, with pretty much the same setup (we also use this envvar substitution in ssl stress compose file). Do we know the docker version on the image?

@rzikm

rzikm commented Jan 22, 2025

Copy link
Copy Markdown
Member

/azp run runtime-libraries stress-ssl

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger

Copy link
Copy Markdown
Member Author

I found some differences in the way docker-compose.yml was structured compared to SslStress, pushed the changes.

@akoeplinger

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries stress-http

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries stress-http

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries stress-http

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov

Copy link
Copy Markdown
Contributor

/azp run runtime-libraries stress-http

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger

Copy link
Copy Markdown
Member Author

@antonfirsov @rzikm looks like this will need a bit more attention than the quick fix I thought, would you mind taking over the PR?

@rzikm rzikm self-assigned this Jan 23, 2025
@rzikm

rzikm commented Jan 23, 2025

Copy link
Copy Markdown
Member

/azp run runtime-libraries stress-http

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger

Copy link
Copy Markdown
Member Author

thanks. something seems to be up with the http 3.0 stress test, if you click "View raw log" on AzDO you see this message from AddressSanitizer infinitely repeated:

2025-01-23T10:59:23.6426519Z [command]/usr/bin/bash /mnt/vss/_work/_temp/8a34c3e2-1855-4ac9-867d-b038953e79cb.sh
2025-01-23T10:59:24.1518371Z Creating network "httpstress_default" with the default driver
2025-01-23T10:59:24.2979341Z Creating httpstress_server_1 ... 
2025-01-23T10:59:24.9334260Z �[1A�[2K
2025-01-23T10:59:24.9335125Z Creating httpstress_server_1 ... �[32mdone�[0m
2025-01-23T10:59:24.9426960Z �[1BCreating httpstress_client_1 ... 
2025-01-23T10:59:25.3407238Z �[1A�[2K
2025-01-23T10:59:25.3411586Z Creating httpstress_client_1 ... �[32mdone�[0m
2025-01-23T10:59:25.3597575Z �[1BAttaching to httpstress_server_1, httpstress_client_1
2025-01-23T10:59:25.3600186Z client_1  | AddressSanitizer:DEADLYSIGNAL
2025-01-23T10:59:25.3604301Z client_1  | AddressSanitizer:DEADLYSIGNAL
2025-01-23T10:59:25.3607983Z client_1  | AddressSanitizer:DEADLYSIGNAL
2025-01-23T10:59:25.3626250Z client_1  | AddressSanitizer:DEADLYSIGNAL
2025-01-23T10:59:25.3627722Z client_1  | AddressSanitizer:DEADLYSIGNAL
2025-01-23T10:59:25.3629272Z client_1  | AddressSanitizer:DEADLYSIGNAL
...

@rzikm

rzikm commented Jan 23, 2025

Copy link
Copy Markdown
Member

That's weird, I can't reproduce this locally, maybe we should disable address sanitizer for now

@rzikm

rzikm commented Jan 23, 2025

Copy link
Copy Markdown
Member

/azp run runtime-libraries stress-http

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger

akoeplinger commented Jan 23, 2025

Copy link
Copy Markdown
Member Author

this might be related since we're now using Ubuntu 22.04 hosts: actions/runner-images#9524

@akoeplinger

Copy link
Copy Markdown
Member Author

Looks like it's green now :)

@rzikm rzikm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@rzikm rzikm merged commit 3b7057b into main Jan 27, 2025
@akoeplinger akoeplinger deleted the akoeplinger-patch-2 branch January 27, 2025 10:02
@antonfirsov antonfirsov linked an issue Jan 28, 2025 that may be closed by this pull request
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 27, 2025
@antonfirsov

Copy link
Copy Markdown
Contributor

/backport to release/9.0-staging

@github-actions github-actions Bot unlocked this conversation Mar 17, 2025
@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/13904193229

@github-actions

Copy link
Copy Markdown
Contributor

@antonfirsov backporting to "release/9.0-staging" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Fix linux build image in eng/pipelines/libraries/stress/http.yml
Using index info to reconstruct a base tree...
M	eng/pipelines/libraries/stress/http.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/libraries/stress/http.yml
Applying: Align docker-compose.yml with the one from SslStress
Using index info to reconstruct a base tree...
M	src/libraries/System.Net.Http/tests/StressTests/HttpStress/docker-compose.yml
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Net.Http/tests/StressTests/HttpStress/docker-compose.yml
CONFLICT (content): Merge conflict in src/libraries/System.Net.Http/tests/StressTests/HttpStress/docker-compose.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 Align docker-compose.yml with the one from SslStress
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[HttpStress] Linux image is running out of disk space

3 participants