Handle OSSL 3.4 change to SAN:othername formatting#111820
Merged
Merged
Conversation
ghost
added
the
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/libraries/System.Security.Cryptography/tests/AsnEncodedDataTests.cs:121
- The error message string contains double colons '::' which seems to be a typo. It should be 'othername: UPN:subjectupn1@example.org'.
isOpenSsl3 ? "othername: UPN::subjectupn1@example.org" : "othername:<unsupported>",
vcsjones
approved these changes
Jan 25, 2025
This was referenced Jan 25, 2025
Member
|
Okay never mind. It's the UPN in the SAN. |
Member
|
/backport to release/9.0-staging |
Member
|
/backport to release/8.0-staging |
Contributor
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/14882206144 |
Contributor
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/14882209529 |
Member
|
8.0 backport failed, but it didn't make a comment because the 9.0 re-locked the PR before 8.0 finished running. I'll do 8.0 manually in a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111818