Skip to content

Fix elfreader for android#119190

Merged
thaystg merged 3 commits into
dotnet:mainfrom
thaystg:dev/thays/fix_elf_reader_android
Aug 29, 2025
Merged

Fix elfreader for android#119190
thaystg merged 3 commits into
dotnet:mainfrom
thaystg:dev/thays/fix_elf_reader_android

Conversation

@thaystg

@thaystg thaystg commented Aug 28, 2025

Copy link
Copy Markdown
Member

This PR fixes an issue with the ELF reader on Android by extending a conditional compilation block to include Android platforms. The change addresses how dynamic entries are handled on Android, treating them as relative virtual addresses (RVAs) rather than absolute addresses.

Copilot AI review requested due to automatic review settings August 28, 2025 20:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with the ELF reader on Android by extending a conditional compilation block to include Android platforms. The change addresses how dynamic entries are handled on Android, treating them as relative virtual addresses (RVAs) rather than absolute addresses.

Key Changes

  • Extended preprocessor condition to include Android (HOST_ANDROID) alongside existing musl and RISC-V64 platforms

@thaystg

thaystg commented Aug 28, 2025

Copy link
Copy Markdown
Member Author

/backport to release/10.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17307193266

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Comment thread src/coreclr/debug/dbgutil/elfreader.cpp Outdated
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@thaystg

thaystg commented Aug 28, 2025

Copy link
Copy Markdown
Member Author

/backport to release/10.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17307334479

Comment thread src/coreclr/debug/dbgutil/elfreader.cpp Outdated
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@thaystg

thaystg commented Aug 28, 2025

Copy link
Copy Markdown
Member Author

/backport to release/10.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17307346724

@thaystg

thaystg commented Aug 28, 2025

Copy link
Copy Markdown
Member Author

Thanks @jkotas, I tested locally and the TARGET_ANDROID worked fine too.

@thaystg thaystg merged commit 47b35bc into dotnet:main Aug 29, 2025
96 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants