Skip to content

[release/8.0] Don't assume all S_IFREG files are seekable#122188

Merged
agocke merged 2 commits into
release/8.0from
backport/pr-120736-to-release/8.0
Dec 5, 2025
Merged

[release/8.0] Don't assume all S_IFREG files are seekable#122188
agocke merged 2 commits into
release/8.0from
backport/pr-120736-to-release/8.0

Conversation

@github-actions

@github-actions github-actions Bot commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

Backport of #120736 to release/8.0

/cc @rzikm

Customer Impact

None, the change is in Debug build only and doesn't affect shipped product.

Regression

No, test failures started after adding/updating AzureLinux3 OS in CI matrix.

Testing

CI passes.

Risk

Low, can be considered test-only change as the changes don't propagate to shipped product.

@wfurt

wfurt commented Dec 4, 2025

Copy link
Copy Markdown
Member

Do we need separate approval or was it covered by the one for 9.0/10.10? And should this be release/8.0 r release/8.0-staging?

@agocke agocke added the Servicing-approved Approved for servicing release label Dec 4, 2025
@agocke

agocke commented Dec 4, 2025

Copy link
Copy Markdown
Member

Tell mode, we're good to go when tests pass.

@agocke agocke enabled auto-merge (squash) December 4, 2025 20:02
@rzikm

rzikm commented Dec 5, 2025

Copy link
Copy Markdown
Member

/ba-g Test failures around X509Certificates are unrelated

@agocke agocke merged commit 103b56e into release/8.0 Dec 5, 2025
170 of 179 checks passed
@rzikm

rzikm commented Dec 5, 2025

Copy link
Copy Markdown
Member

Do we need separate approval or was it covered by the one for 9.0/10.10? And should this be release/8.0 r release/8.0-staging?

It should be release/8.0-staging (facepalm), and it got automerged so I noticed too late

@ViktorHofer what should we do in this case?

@jozkee

jozkee commented Dec 5, 2025

Copy link
Copy Markdown
Member

what should we do in this case?

@rzikm nothing, staging is there just to let authors merge their own changes without having to wait for folks with admin permissions.

Keep targeting staging in the future since that will test your change with all other changes in the release. Of course, this does not apply for 10.0 servicing.

@jkotas jkotas deleted the backport/pr-120736-to-release/8.0 branch December 7, 2025 12:44
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants