Fix Handle Leak#126193
Merged
MichalStrehovsky merged 2 commits intoMar 30, 2026
Merged
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
MichalStrehovsky
approved these changes
Mar 27, 2026
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
Member
There was a problem hiding this comment.
Cc @tmat, this file is just a copy https://github.com/dotnet/sourcelink/blob/main/src/SourceLink.Tools/SourceLinkMap.cs fixed up not to trigger warnings in our build, we don't really want to maintain it.
Member
|
/ba-g timeout in an unrelated leg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HANDLE_LEAK JsonDocument.Parse(json, new JsonDocumentOptions() { AllowTrailingCommas = true }) becomes out of scope and is not disposed
A copy of the string is extracted from the object (jsonDocument.RootElement.....Value.EnumerateObject()->Value.GetString()) , so it is not needed when the method completes. 'using' operator is safe here.
Found by Linux Verification Center (linuxtesting.org) with SVACE.