JIT: Remove SSE2 CmpOp/BinOp emulation code#126266
Merged
Merged
Conversation
github-actions
Bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes now-unreachable SSE2-era emulation paths for SIMD integer comparison operations in the CoreCLR JIT, based on the updated xarch baseline (SSE4.2) making the direct hardware intrinsics consistently available.
Changes:
- Removed SSE2 fallback/emulation implementations for
Vector<long>equality andlonggreater/less-than comparisons. - Simplified unsigned
GT_GT/GT_LTlowering by usingEvaluateBroadcastInPlacefor the bias constant vector. - Centralized xarch-only invariants as assertions (integral base type, non-EVEX path, and supported SIMD sizes).
saucecontrol
changed the title
Member
Author
|
cc @dotnet/jit-contrib This just removes more dead code. No diffs. |
Member
|
/azp list |
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
/azp run runtime-coreclr jitstress-isas-x86 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
EgorBo
approved these changes
Mar 29, 2026
EgorBo
left a comment
EgorBo
left a comment
Member
There was a problem hiding this comment.
Thanks! Let's make sure the pipeline where we disable various ISAs doesn't regress
tannergooding
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the JIT baseline now at SSE4.2, these fallback implementations are no longer reachable.