Repository navigation

Follow-up to #126192: address review comments (doc nit, ShellExecuteHelper refactor, field keyword, test, trimming, waitStateHolder fix) - #126314

Merged

adamsitnik merged 19 commits into

mainfrom

copilot/follow-up-pr-126192-comments

Mar 31, 2026

Merged

Follow-up to #126192: address review comments (doc nit, ShellExecuteHelper refactor, field keyword, test, trimming, waitStateHolder fix)#126314
adamsitnik merged 19 commits into
mainfrom
copilot/follow-up-pr-126192-comments

Commits on Mar 30, 2026
- Address review comments: fix "OS handle" doc nit, convert ShellExecuteHelper to private static methods
  
  Copilot
  and
  adamsitnik
  committed
  716f641
- Use field keyword for ProcessId; add test for invalid handle validation
  
  Copilot
  and
  adamsitnik
  committed
  7b2fad9
- Pass SHELLEXECUTEINFO by value; return hProcess/hInstApp via out params
  
  Copilot
  and
  adamsitnik
  committed
  2a8a779
- Replace notPresent bool with ERROR_CALL_NOT_IMPLEMENTED in catch block
  
  Copilot
  and
  jkotas
  committed
  6658eef
- Rename StartWithShellExecuteEx to StartWithShellExecute
  
  Copilot
  and
  jkotas
  committed
  79f4362
- Fold ShellExecuteOnSTAThread into StartWithShellExecute; add static delegate for UseShellExecute trimming
  
  Copilot
  and
  jkotas
  committed
  ebb8524
- Move UseShellExecute property to shared ProcessStartInfo.cs
  
  Copilot
  and
  adamsitnik
  committed
  8b4d138
- Fold StartWithCreateProcess into StartCore on Windows
  
  Copilot
  and
  jkotas
  committed
  1b6b78f
- Move s_startWithShellExecute to platform files, EnsureShellExecuteFunc to shared, GetShellError to local function
  
  Copilot
  and
  jkotas
  committed
  a774a37
- Unix StartCore: move UseShellExecute delegate call after shared platform checks
  
  Copilot
  and
  jkotas
  committed
  22abeac
- Make s_startWithShellExecute private in both platform files
  
  Copilot
  and
  jkotas
  committed
  82c81f5
Commits on Mar 31, 2026