Agentics: Add Extensions & Compression review agent and instructions#126638
Merged
Conversation
Add three types of Copilot artifacts for Microsoft.Extensions.* and
System.IO.Compression code review and development guidance:
1. Review Agent (.github/agents/extensions-reviewer.md):
- 12 overarching principles for Extensions/Compression review
- 20 review dimensions with 106 CHECK items
- Routing table mapping feature areas to dimensions
- 5-wave review workflow
2. Skill (.github/skills/extensions-review/SKILL.md):
- Decision trees for DI lifetime, config binding, options validation
- Code examples for common patterns
- Testing guidance specific to Extensions/Compression
- Delegates to @extensions-reviewer for full code review
3. Instruction files (.github/instructions/):
- 8 folder-specific instruction files with applyTo globs
- Configuration, DI, Logging, Hosting, Caching, Options,
Compression, and common Extensions libraries
- Concise, actionable bullet points per area
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- D1: Replace generic naming rule with Extensions naming taxonomy - D4: Broaden SafeHandle to cover ChangeToken/ICacheEntry/FileWatcher disposal - D5: Name actual hot paths per library (DI resolution, Logger.Log, etc.) - D9: Replace misplaced platform-error-codes with domain-specific exceptions - D15: Replace factually wrong health-check rule with IHostedLifecycleService ordering - D18: Replace generic dead-code/accidental-files with shared-code and test patterns - Skill: Narrow trigger words to avoid overtriggering on Extensions.AI etc. - Instructions: Remove 5 duplicated rules across instruction files Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Applied 7 consensus fixes from 3-model review (Opus, Codex, Gemini): 1. Strip all vote/weight/PR-count statistics (zero runtime value) 2. Deduplicate SKILL.md key-rules that repeated instruction files 3. Remove generic C#/.NET rules already known to model/copilot-instructions 4. Fix factual errors: CompressionLevel, agent name, interceptor, encryption 5. Make CHECKs principle-based not implementation-specific 6. Add HybridCache .NET 9+ availability note 7. Trim redundant trigger words (23 -> 10, one per area) Net: -88 lines, 868 total (from 956). Zero contamination verified. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Copilot agentic assets for reviewing and authoring changes in Microsoft.Extensions.* and System.IO.Compression within dotnet/runtime, including a dedicated review agent, a writing skill, and folder-scoped instruction files.
Changes:
- Introduces a new “Extensions & Compression” review agent (
extensions-reviewer) with dimension-based checks. - Adds a writing skill for Extensions/Compression implementation guidance.
- Adds folder-scoped instruction files for key Extensions areas (DI, Configuration, Logging, Hosting, Options, Caching, Common libs) plus Compression.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/skills/extensions-review/SKILL.md | Adds a writing skill with implementation guidance and examples for Extensions + Compression. |
| .github/instructions/extensions-options.instructions.md | Adds Options-specific folder guidance (validation, monitor, generator parity). |
| .github/instructions/extensions-logging.instructions.md | Adds Logging-specific guidance (LoggerMessage generator, security, performance). |
| .github/instructions/extensions-hosting.instructions.md | Adds Hosting lifecycle and test reliability guidance. |
| .github/instructions/extensions-di.instructions.md | Adds DI lifetimes, resolution, trim/AOT, and test guidance. |
| .github/instructions/extensions-configuration.instructions.md | Adds Configuration binding and source-generator parity guidance. |
| .github/instructions/extensions-common.instructions.md | Adds combined guidance for Http, FileProviders, and Primitives. |
| .github/instructions/extensions-caching.instructions.md | Adds caching correctness/perf guidance (keys, eviction, stampede prevention). |
| .github/instructions/compression.instructions.md | Adds Compression guidance (format correctness, security, perf, interop testing). |
| .github/agents/extensions-reviewer.md | Adds a dedicated review agent with principles, dimensions, routing, and workflow. |
cincuranet
approved these changes
Apr 8, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Drop all (Dx, Dy) dimension pointers that could drift from the agent doc, and replace the verbose Microsoft.Extensions.* package listing in the description with a single wildcard. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The 'writing-extensions-code' skill name no longer exists (renamed to extensions-review). Rather than update the pointers, remove the 'For deeper guidance' footer lines entirely from all 8 instruction files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Instruct the extensions-reviewer agent to launch one claude-opus-4.6 sub-agent per dimension in Wave 1, running all dimensions in parallel. Each sub-agent gets the full briefing pack plus its assigned dimension and CHECK items. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rosebyte
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Copilot agentic artifacts for Microsoft.Extensions.* and System.IO.Compression libraries — a review agent, a writing skill, and
folder-scoped instruction files for various extensions areas.
Includes a follow-up review pass, explicitly invokable as a separate agent.