[ci-fix] Use DoNotWrapExceptions across ReflectionMemberAccessor Invoke paths by github-actions[bot] · Pull Request #129212 · dotnet/runtime

github-actions · 2026-06-10T02:05:55Z

Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #128766

> [!NOTE]
> This is an AI/Copilot-generated fix updated after PR feedback and validated with targeted local build/test runs.

Root cause (best analysis)

AsyncEnumerableTests.SerializeAsyncEnumerable_*_PartialItemFailure_PriorItemsAreFullyWritten fails on tvos-arm64 AllSubsets_Mono because the test expects InvalidOperationException but receives TargetInvocationException.

The failing log line:

[FAIL] ...AsyncEnumerableTests_AsyncPipeSerializer.SerializeAsyncEnumerable_TopLevelValues_PartialItemFailure_PriorItemsAreFullyWritten
Expected: typeof(System.InvalidOperationException)
Actual:   typeof(System.Reflection.TargetInvocationException)

On Mono/tvOS (AOT environments), System.Text.Json uses ReflectionMemberAccessor, where reflection Invoke can wrap target exceptions. CoreCLR commonly uses ReflectionEmitMemberAccessor, which propagates underlying exceptions directly.

Attempted fix

Updated ReflectionMemberAccessor to apply BindingFlags.DoNotWrapExceptions on NET targets across relevant reflection Invoke call sites in the file (including property accessors and other Invoke usages raised in review), while preserving non-NET compatibility paths.

Additional polish from feedback:

Kept exception behavior aligned with ReflectionEmitMemberAccessor for add-method delegate behavior.
Improved null-handling/diagnostics for union accessor delegate creation.

What is unverified / where I need help

Full matrix/platform validation (especially tvOS Mono) still depends on CI legs; local validation was targeted.

Validation

./build.sh clr+libs -rc release ✅
./build.sh clr+libs+host -rc release -lc release ✅
dotnet build src/libraries/System.Text.Json/src/System.Text.Json.csproj -c Release ✅
dotnet build /t:test src/libraries/System.Text.Json/tests/System.Text.Json.Tests/System.Text.Json.Tests.csproj -p:Configuration=Release /p:XunitMethodName=System.Text.Json.Serialization.Tests.AsyncEnumerableTests_AsyncPipeSerializer.SerializeAsyncEnumerable_TopLevelValues_PartialItemFailure_PriorItemsAreFullyWritten ✅

Evidence

Failing build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1438268
First build it occurred: build 1433744, finished 2026-05-25T09:02:27Z (computed within scanned window; may not be true origin)
Suspected regressing change: none identified with sufficient confidence

Help wanted

Area owners (area-System.Text.Json): @StephenMolloy, @dotnet/area-system-text-json

Filed by ci-failure-fix. Comment here or on the workflow file to suggest changes; ci-failure-scan-feedback reads in-scope feedback daily and opens (or updates) a PR with prompt edits.

> [!WARNING]
>

> Generated by CI Outer-Loop Failure Fixer · ● 35M · ◷

… accessors On Mono/tvOS (AOT environments), System.Text.Json uses ReflectionMemberAccessor which calls MethodInfo.Invoke() for property getters/setters. This wraps any exception thrown by the property in TargetInvocationException, unlike CoreCLR which uses IL-emitted delegates that propagate exceptions directly. The constructor delegates in the same class already unwrap TargetInvocationException; this commit adds the same treatment to CreatePropertyGetter and CreatePropertySetter using ExceptionDispatchInfo.Capture to preserve the original stack trace. Fixes the tvOS Mono test failure where AsyncEnumerableTests.SerializeAsyncEnumerable_PartialItemFailure tests expect InvalidOperationException but receive TargetInvocationException. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>

jkotas · 2026-06-16T15:03:35Z

            {
-                return (TProperty)getMethodInfo.Invoke(obj, null)!;
+#if NET
+                return (TProperty)getMethodInfo.Invoke(


There are other Invoke method calls in this file. Do all of them need the same treatment?

@copilot resolve this comment

Addressed in 6e9eede. I audited the other Invoke call sites in ReflectionMemberAccessor and updated them to use BindingFlags.DoNotWrapExceptions on NET (with existing non-NET compatibility paths preserved).

Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>

jkotas · 2026-06-17T12:51:13Z

+                    parameters: new object[] { element! },
+                    culture: null);
+#else
                addMethod.Invoke(collection, new object[] { element! });


Should this catch and rethrow the exception like the other cases?

jkotas · 2026-06-17T12:51:44Z

@@ -130,6 +164,7 @@ public override JsonTypeInfo.ParameterizedConstructorDelegate<T, TArg0, TArg1, T
                {
                    throw e.InnerException ?? e;


Should the pattern for catch and rethrow be consistent across all cases?

jkotas · 2026-06-17T12:53:33Z

+                if (accessor is null)
+                {
+                    throw new InvalidOperationException(
+                        $"Failed to create union accessor for type '{entry.Key}' using method '{entry.Value}'.");


This unrelated change. It should be left for separate PR (and tests should be added to cover it in that PR)

github-actions Bot added the agentic-workflows label Jun 10, 2026

ci: trigger checks

9579fbe

github-actions Bot added the area-System.Text.Json label Jun 10, 2026

This was referenced Jun 10, 2026

System.Net.NameResolution.Tests DNS failures: Name or service not known #126641

Open

DnsGetHostAddresses_LocalhostWithTrailingDot_ReturnsLoopback - SocketException : Name or service not known #128759

Open

github-actions Bot mentioned this pull request Jun 10, 2026

[ci-scan-feedback] KPI Tracker #128742

Open

kotlarmilos changed the title ~~[ci-fix] Needs review: Unwrap TargetInvocationException in ReflectionMemberAccessor property accessors (refs #128766)~~ [ci-fix] Unwrap TargetInvocationException in ReflectionMemberAccessor property accessors Jun 10, 2026

jkotas reviewed Jun 10, 2026

View reviewed changes

Comment thread ...ies/System.Text.Json/src/System/Text/Json/Serialization/Metadata/ReflectionMemberAccessor.cs

github-actions Bot mentioned this pull request Jun 14, 2026

[aw] No-Op Runs #128986

Closed

Copilot started work on behalf of kotlarmilos June 16, 2026 10:12 View session

Use DoNotWrapExceptions for ReflectionMemberAccessor property accessors

c357fbb

Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>

Copilot finished work on behalf of kotlarmilos June 16, 2026 10:49

Copilot AI requested a review from kotlarmilos June 16, 2026 10:49

jkotas reviewed Jun 16, 2026

View reviewed changes

build-analysis Bot mentioned this pull request Jun 16, 2026

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

Copilot started work on behalf of kotlarmilos June 17, 2026 06:36 View session

Copilot AI and others added 6 commits June 17, 2026 07:11

Apply DoNotWrapExceptions to remaining reflection Invoke calls

b6b94f7

Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>

Adjust constructor invoke paths for DoNotWrapExceptions on NET only

5c1d406

Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>

Normalize Invoke overload usage in ReflectionMemberAccessor

91768ba

Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>

Clarify add-method exception semantics and remove null-forgiving cast

8a0b1d0

Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>

Add context to union accessor creation failure

102e407

Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>

Refine union accessor Invoke null handling

6e9eede

Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>

Copilot AI changed the title ~~[ci-fix] Unwrap TargetInvocationException in ReflectionMemberAccessor property accessors~~ [ci-fix] Use DoNotWrapExceptions across ReflectionMemberAccessor Invoke paths Jun 17, 2026

Copilot finished work on behalf of kotlarmilos June 17, 2026 07:20

jkotas reviewed Jun 17, 2026

View reviewed changes

github-actions Bot mentioned this pull request Jun 18, 2026

[aw] No-Op Runs #129501

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ci-fix] Use DoNotWrapExceptions across ReflectionMemberAccessor Invoke paths#129212

[ci-fix] Use DoNotWrapExceptions across ReflectionMemberAccessor Invoke paths#129212
github-actions[bot] wants to merge 9 commits into
mainfrom
ci-fix/reflection-unwrap-tie-128766-da9341c6f0fcce74

github-actions Bot commented Jun 10, 2026 •

edited by Copilot AI

Loading

Uh oh!

Uh oh!

jkotas Jun 16, 2026

Uh oh!

kotlarmilos Jun 17, 2026

Uh oh!

Copilot AI Jun 17, 2026

Uh oh!

jkotas Jun 17, 2026

Uh oh!

jkotas Jun 17, 2026

Uh oh!

jkotas Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -130,6 +164,7 @@ public override JsonTypeInfo.ParameterizedConstructorDelegate<T, TArg0, TArg1, T
		{
		throw e.InnerException ?? e;

Conversation

github-actions Bot commented Jun 10, 2026 • edited by Copilot AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Root cause (best analysis)

Attempted fix

What is unverified / where I need help

Validation

Evidence

Help wanted

Uh oh!

Uh oh!

jkotas Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

kotlarmilos Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

jkotas Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

jkotas Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

jkotas Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jun 10, 2026 •

edited by Copilot AI

Loading