Merge JIT Generics tests into explicit runners by jkoritzinsky · Pull Request #132167 · dotnet/runtime

jkoritzinsky · 2026-08-11T20:40:30Z

Summary

The JIT Generics merged runner used recursive project globs, which obscured the build-property groups and prevented tests from being folded into the runner assembly.

Replace the glob-based runner with six explicit runners grouped by DebugType and Optimize.
Compile eligible C# test sources directly into the runners, using unique namespaces to avoid symbol collisions, while retaining IL project references.
Preserve priority-1 scheduling with [OuterLoop].
Convert the Windows-only P/Invoke and getclassfrommethodparam tests from process-isolated projects to platform-filtered tests in JIT.Generics.
Remove the 212 per-test C# project wrappers that are no longer needed.

Testing

build.cmd clr+libs -lc release -rc checked
src\tests\build.cmd -Dir JIT\Generics x64 Checked -Priority 1
Executed all six merged runners against the Checked Core_Root; each returned 100 with no failures.
Re-executed JIT.Generics and JIT.Generics_r after consolidating the Windows-only tests; both returned 100 with no failures.

Note

This pull request description was generated by GitHub Copilot.

Replace the glob-based Generics runner with explicit project lists grouped into normalized DebugType and Optimize variants. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

azure-pipelines · 2026-08-11T20:41:19Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-08-11T20:46:09Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

jkoritzinsky · 2026-08-18T00:21:44Z

/azp run runtime

azure-pipelines · 2026-08-18T00:22:13Z

Azure Pipelines: Successfully started running 1 pipeline(s).

azure-pipelines · 2026-08-18T02:19:32Z

No pipelines are associated with this pull request.

azure-pipelines · 2026-08-18T02:20:17Z

No pipelines are associated with this pull request.

azure-pipelines · 2026-08-18T02:20:18Z

No pipelines are associated with this pull request.

jkoritzinsky · 2026-08-18T02:23:06Z

/azp run runtime

Note

This CI retry command was generated by GitHub Copilot.

azure-pipelines · 2026-08-18T02:23:33Z

Azure Pipelines: Successfully started running 1 pipeline(s).

azure-pipelines · 2026-08-18T02:23:41Z

No pipelines are associated with this pull request.

jkoritzinsky · 2026-08-18T17:24:12Z

/ba-g misclassified build error for KBE test failure

## Summary PR #132167 compiled `chaos65204782cs.cs` into both merged `JIT.Generics` runners. Mono FullAOT rejects its recursive generic metadata, causing the entire runners to fail AOT compilation. Restore the dedicated test project and: - run it process-isolated in normal configurations - exclude only this test from Mono MiniFullAOT/LLVMFullAOT - keep both merged `JIT.Generics` runners enabled for FullAOT coverage The standalone project remains referenced by the PdbOnly runner so it participates in normal test execution. ## Validation MSBuild evaluation confirmed: - normal builds discover one runnable process-isolated test - Mono MiniFullAOT disables only the standalone project - both merged runners remain enabled The full build was not run because the pinned SDK was unavailable from its feeds. Addresses #132942 without closing it, since the issue also tracks the underlying Mono AOT recursion failure. > [!NOTE] > This pull request description was generated with GitHub Copilot. Fixes: #132942 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

jkoritzinsky and others added 2 commits August 11, 2026 11:27

Modernize JIT Generics merged runners

13061d6

Replace the glob-based Generics runner with explicit project lists grouped into normalized DebugType and Optimize variants. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Merge JIT Generics tests into runners

96349d9

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI lite review requested due to automatic review settings August 11, 2026 20:40

Copilot AI reviewed Aug 11, 2026

github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 11, 2026

dotnet-policy-service Bot assigned jkoritzinsky Aug 11, 2026

github-project-automation Bot added this to AppModel Aug 11, 2026

sbomer reviewed Aug 13, 2026

View reviewed changes

Comment thread src/tests/JIT/Generics/JIT.Generics_r.csproj Outdated

Comment thread src/tests/JIT/Generics/JIT.Generics.csproj

Preserve JIT Generics optimization settings

1f03e53

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings August 17, 2026 18:24

Copilot AI reviewed Aug 17, 2026

jkoritzinsky requested review from EgorBo and sbomer August 17, 2026 20:53

sbomer approved these changes Aug 17, 2026

View reviewed changes

EgorBo approved these changes Aug 17, 2026

View reviewed changes

jkoritzinsky enabled auto-merge (squash) August 18, 2026 00:21

build-analysis Bot mentioned this pull request Aug 18, 2026

Assert failure: !"OBJECTREF being accessed while thread is in preemptive GC mode." #131925

Open

jkoritzinsky merged commit bf7a865 into main Aug 18, 2026
59 of 61 checks passed

jkoritzinsky deleted the dev/jkoritzinsky/split-generics-runners branch August 18, 2026 17:24

github-project-automation Bot moved this to Done in AppModel Aug 18, 2026

dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Aug 21, 2026

This was referenced Sep 1, 2026

[ci-scan] Build break: Mono MiniFullAOT compile of JIT.Generics fails with MSB3077 (Recursive type definition detected) #132942

Closed

Restore chaos65204782cs as a standalone JIT test #133039

Merged

github-actions Bot locked and limited conversation to collaborators Sep 20, 2026

Conversation

jkoritzinsky commented Aug 11, 2026

Summary

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines Bot commented Aug 11, 2026

Uh oh!

dotnet-policy-service Bot commented Aug 11, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

jkoritzinsky commented Aug 18, 2026

Uh oh!

azure-pipelines Bot commented Aug 18, 2026

Uh oh!

azure-pipelines Bot commented Aug 18, 2026

Uh oh!

azure-pipelines Bot commented Aug 18, 2026

Uh oh!

azure-pipelines Bot commented Aug 18, 2026

Uh oh!

jkoritzinsky commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines Bot commented Aug 18, 2026

Uh oh!

azure-pipelines Bot commented Aug 18, 2026

Uh oh!

jkoritzinsky commented Aug 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jkoritzinsky commented Aug 18, 2026 •

edited

Loading