[release/10.0] Deduplicate "all managed object wrappers" mapping - #133292
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/interop-contrib |
AaronRobinsonMSFT
approved these changes
Sep 8, 2026
JulieLeeMSFT
added
Servicing-approved
naveen-devang
added a commit
to naveen-devang/Procure
that referenced
this pull request
Sep 13, 2026
… x:Bind
Measured on the release build against a copy of the real database, opening and closing one PR's
detail panel 60 times: private memory 224 MB -> 155 MB, managed heap 24 MB -> 9 MB, about half the CPU
per open, handles no longer climb.
- The panel was rebuilt on every open (x:Load bound to the open flag) and WinUI never gave all of
it back: ~1 MB and ~3 handles more per open. It is now built on the first open (FindName) and its
Visibility follows the flag; the slide-in replays on each open.
- Its {Binding}s (and the slide-over header's) are x:Bind. A {Binding} listens through native code,
so every PropertyChanged hands the PR to WinRT, and .NET 10.0.12's ComWrappers appends each hand-off
to a list that is never trimmed (dotnet/runtime#133292, fixed in 10.0.13): 20 opens left 1.18
million entries on one PR.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XY1a3Ayfsk5D1TwB3JXTin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #133260 to release/10.0
/cc @jkoritzinsky
Customer Impact
Ever increasing managed memory usage (memory leak) each time a managed object is passed to COM via ComWrappers, even when reusing the same COM instance. The only workaround is to turn off the "managed debugging" helper APIs.
Regression
Regressed in #113907
Testing
Local validation via SOS (the only direct exposure of the adjusted API)
Risk
Low, only affects an API exposed to SOS (no other consumers use it). As mentioned in the PR on main, the expected number of elements in the collection when deduplicated is 1 or 2 at most, so not using a hash-table is fine for the scenario (in particular the user-reported issue will have 1 item in the collection after the fix).
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.release/X.0(no-stagingsuffix).Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.