JIT: Remove unused promoted loop definitions - #133447
Open
jakobbotsch wants to merge 2 commits into
Open
jakobbotsch wants to merge 2 commits into
jakobbotsch wants to merge 2 commits into
Conversation
`LCL_ADDR` propagation only records assertions for locals that are neither promoted nor struct fields. Expanding loop stores into promoted parents and field locals therefore adds map entries that can never invalidate an assertion. Early versions of `LCL_ADDR` propagation attempted to support promoted locals and their fields, which required this bookkeeping. Remove it now that those assertions are not supported. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a64a400a-c6c5-492a-9e23-2de29e4612ce
github-actions
Bot
added
the
area-CodeGen-coreclr
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Sep 9, 2026
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Removes obsolete promoted-local and struct-field bookkeeping from JIT loop-definition tracking.
Changes:
- Retains direct local-store definitions.
- Simplifies
LoopDefinitions::GetOrCreateMap.
File summaries
| File | Description |
|---|---|
src/coreclr/jit/lclmorph.cpp |
Removes unused promoted-local and field map entries. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
This was referenced Sep 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LCL_ADDRpropagation only records assertions for locals that are neither promoted nor struct fields. Expanding loop stores into promoted parents and field locals therefore adds map entries that can never invalidate an assertion.Early versions of
LCL_ADDRpropagation attempted to support promoted locals and their fields, which required this bookkeeping. Remove it now that those assertions are not supported.