Match old layouts and feature selection for named mutexes for cross-TFM compatibility - #134541
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @VSadov |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
One or more issues must be addressed before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Updates named mutex shared-memory layouts and backend selection to preserve cross-TFM compatibility with older .NET versions.
Changes:
- Widens owner thread IDs to 64 bits.
- Aligns managed/native layouts with the legacy PAL format.
- Uses file-lock mutexes on Linux ARM/ARM64.
| File | Description |
|---|---|
| src/native/libs/System.Native/pal_crossprocessmutex.h | Updated as part of this pull request. |
| src/native/libs/System.Native/pal_crossprocessmutex.c | Updated as part of this pull request. |
| src/native/libs/System.Native/pal_crossprocessmutex_unsupported.c | Updated as part of this pull request. |
| src/libraries/System.Private.CoreLib/src/System/Threading/NamedMutex.Unix.cs | Updated as part of this pull request. |
| src/libraries/Common/src/Interop/Unix/System.Native/Interop.LowLevelCrossProcessMutex.cs | Updated as part of this pull request. |
am11
reviewed
Sep 23, 2026
jkoritzinsky
enabled auto-merge (squash)
September 24, 2026 00:34
This was referenced Sep 24, 2026
jkotas
reviewed
Sep 24, 2026
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Resolve the compatibility and migration issues between old and new mutex layouts before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Resolved since last review (1)
jkotas
approved these changes
Sep 24, 2026
Member
Author
|
/backport to release/11.0 |
Contributor
|
Started backporting to |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #134491 by using a uint64 for thread id and using non-pthread based mutexes for linux arm and linux arm64.