Skip to content

Add method-list MIBC writer to dotnet-pgo #134566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lewing merged 3 commits into from
Sep 24, 2026
Merged

Add method-list MIBC writer to dotnet-pgo #134566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e99f7f
Add method-list MIBC writer to dotnet-pgo
lewing Sep 24, 2026
b24f916
Fix method-list MIBC determinism and validation
lewing Sep 24, 2026
fb45dfb
Always validate method-list MIBC output
lewing Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions eng/Subsets.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,8 @@
Test="true" Category="clr" Condition="'$(DotNetBuildSourceOnly)' != 'true'"/>
<ProjectToBuild Include="$(CoreClrProjectRoot)tools\ILTrim.Tests\ILTrim.Tests.csproj"
Test="true" Category="clr" Condition="'$(DotNetBuildSourceOnly)' != 'true'"/>
<ProjectToBuild Include="$(CoreClrProjectRoot)tools\dotnet-pgo\tests\dotnet-pgo.Tests.csproj"
Test="true" Category="clr" Condition="'$(DotNetBuildSourceOnly)' != 'true'"/>
</ItemGroup>

<ItemGroup Condition="$(_subset.Contains('+clr.r2rtests+'))">
Expand Down
44 changes: 27 additions & 17 deletions src/coreclr/tools/Common/TypeSystem/Common/Utilities/CustomAttributeTypeNameParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,16 @@ public static TypeDesc GetTypeByCustomAttributeTypeName(this ModuleDesc module,
}.Resolve(parsed);
}

/// <summary>
/// Determines whether <paramref name="name"/> is a valid assembly-qualified type name,
/// including assembly qualification for constructed generic arguments.
/// </summary>
public static bool IsAssemblyQualifiedTypeName(string name)
{
return TypeName.TryParse(name.AsSpan(), out TypeName parsed, s_typeNameParseOptions)
&& IsFullyQualified(parsed);
}

public static TypeDesc GetTypeByCustomAttributeTypeNameForDataFlow(string name, ModuleDesc callingModule,
TypeSystemContext context, List<ModuleDesc> referencedModules, bool needsAssemblyName, bool fallbackToCoreLib, out bool failedBecauseNotFullyQualified)
{
Expand Down Expand Up @@ -65,32 +75,32 @@ public static TypeDesc GetTypeByCustomAttributeTypeNameForDataFlow(string name,
TypeDesc type = resolver.Resolve(parsed);

return type;
}

static bool IsFullyQualified(TypeName typeName)
private static bool IsFullyQualified(TypeName typeName)
{
if (typeName.AssemblyName is null)
{
if (typeName.AssemblyName is null)
{
return false;
}
return false;
}

if (typeName.IsArray || typeName.IsPointer || typeName.IsByRef)
{
return IsFullyQualified(typeName.GetElementType());
}
if (typeName.IsArray || typeName.IsPointer || typeName.IsByRef)
{
return IsFullyQualified(typeName.GetElementType());
}

if (typeName.IsConstructedGenericType)
if (typeName.IsConstructedGenericType)
{
foreach (TypeName typeArgument in typeName.GetGenericArguments())
{
foreach (var typeArgument in typeName.GetGenericArguments())
if (!IsFullyQualified(typeArgument))
{
if (!IsFullyQualified(typeArgument))
{
return false;
}
return false;
}
}

return true;
}

return true;
}

private struct TypeNameResolver
Expand Down
Loading
Loading