Repository navigation
Avoid frame identity for leaf Wasm funclets - #134608
Draft
davidwrighton wants to merge 1 commit into
Draft
davidwrighton wants to merge 1 commit into
davidwrighton wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Oct 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wasm funclet frames currently store their function-table index even when the funclet cannot call another function. The index identifies a suspended caller during stack walking, so call-free funclets do not need it.
This change determines whether each funclet can emit a call from lowered IR before code generation. Call-free funclets retain their frame and virtual-IP tracking for EH, but omit the function-identity store. Calling funclets and root functions are unchanged. Call emission also retains a Checked assertion and a Release backstop so future implicit-call paths cannot leave the identity slot uninitialized.
Measured on a Release browser Wasm
System.Private.CoreLibbuild:System.Private.CoreLib.wasmDisassembly classification found all 162 call-free funclets omitted the identity store, while all 1,833 calling funclets retained it.
Validation:
./build.sh -os browser -c Release -subset clr+libs./build.sh clr.wasmjit+clr.corelib+clr.nativecorelib -os browser -c Checkedgit diff --checkResolves #134597
Note
This pull request description was generated with GitHub Copilot.