Disable async tests on Wasm R2R - #134643
Open
akoeplinger wants to merge 3 commits into
Open
akoeplinger wants to merge 3 commits into
akoeplinger wants to merge 3 commits into
Conversation
Temporarily disable Async2TaskAdapters.WrapValueVersusAsync only for Wasm ReadyToRun configurations while #133953 tracks the MethodTable validation assertion. Other Wasm modes, platforms, and sibling async tests remain enabled. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: aab39968-c93b-478a-acee-e9f7b2eefc26
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke |
radekdoulik
approved these changes
Sep 25, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted quarantine preserves all other test coverage.
Review effort: Lite
Findings: None
What changed in this PR
Temporarily quarantines WrapValueVersusAsync for Wasm ReadyToRun configurations.
Changes:
- Adds an
ActiveIssuelinked to issue #133953. - Preserves coverage for other configurations.
- No tests run; attribute-only change.
| File | Description |
|---|---|
src/tests/async/async-versions-task-adapters/async-versions-task-adapters.cs |
Adds the scoped Wasm ReadyToRun test exclusion. |
The original quarantine allowed the async work item to progress to AwaitNotAsync.AsyncEntryPoint, which hits the same MethodTable SanityCheck assertion tracked by #133953. Quarantine that method under the same Wasm ReadyToRun condition while preserving every other configuration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: aab39968-c93b-478a-acee-e9f7b2eefc26
akoeplinger
changed the title
After the earlier async quarantines, the Wasm R2R lane reaches GenericVirtualMethod.Program.TestGenericVirtualMethod and asserts in ProcessDynamicDictionaryLookup. Quarantine only that method against #134660 while retaining sibling covariant-return tests and all other configurations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: aab39968-c93b-478a-acee-e9f7b2eefc26
radekdoulik
approved these changes
Sep 25, 2026
akoeplinger
enabled auto-merge (squash)
September 25, 2026 16:11
Open
3 tasks
lewing
approved these changes
Sep 25, 2026
Member
|
cc @jakobbotsch |
jakobbotsch
approved these changes
Sep 25, 2026
Member
|
#134676 should fix the underlying issue and we should make sure to reenable the async tests if this merges before it |
Member
Author
|
hm yeah looks like there are still more tests that need to be disabled and #134676 seems to be green so yeah maybe let's just take that one. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Async2TaskAdapters.WrapValueVersusAsyncandAwaitNotAsync.AsyncEntryPointfor Wasm ReadyToRun configurations against Async2TaskAdapters.TestValueTaskOfTaskValueVersusAsync fails with SanityCheck() in Wasm R2R test #133953GenericVirtualMethod.Program.TestGenericVirtualMethodfor Wasm ReadyToRun against Wasm R2R test failure: GenericVirtualMethod.Program.TestGenericVirtualMethod #134660Note
This pull request description was generated by GitHub Copilot.