Skip to content

Fix contract violation in CachedInterfaceDispatch #134731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 1 commit into from
Sep 27, 2026
Merged

Fix contract violation in CachedInterfaceDispatch #134731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/coreclr/vm/prestub.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3079,19 +3079,23 @@ EXTERN_C PCODE STDCALL ExternalMethodFixupWorker(
}
#endif // !TARGET_WASM

GCX_COOP_THREAD_EXISTS(CURRENT_THREAD);

// We lost the race or the R2R image was generated without cached interface dispatch support, simply do the resolution in pure C++
MethodTable* objectType;
{
GCX_COOP_THREAD_EXISTS(CURRENT_THREAD);
objectType = (*protectedObj)->GetMethodTable();
}

DispatchToken token;
if (pMT->IsInterface())
{
GCX_COOP_THREAD_EXISTS(CURRENT_THREAD);
token = pMT->GetLoaderAllocator()->GetDispatchToken(pMT->GetTypeID(), slot);
MethodTable* objectType = (*protectedObj)->GetMethodTable();
VirtualCallStubManager::Resolver(objectType, token, protectedObj, &pCode, TRUE /* throwOnConflict */);
}
else
{
pCode = (*protectedObj)->GetMethodTable()->GetRestoredSlot(slot); // Ensure that the target slot has an entrypoint
pCode = objectType->GetRestoredSlot(slot); // Ensure that the target slot has an entrypoint
}
}
#endif // FEATURE_CACHED_INTERFACE_DISPATCH
Expand Down
Loading