Repository navigation
Fix SslStream handling of empty TLS handshake records - #134921
Merged
Merged
Conversation
Validate the current record length before both ClientHello probes and throw IOException for empty handshake records. Add regression coverage for certificate sources, sync and async authentication, fragmented input, read-ahead, and both handshake implementations. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
wfurt
reviewed
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recognizing exactly-five-byte TLS records exposed unchecked handshake-type reads in
SslStream.ReceiveHandshakeFrameAsync. An empty handshake record (16 03 01 00 00) currently throwsIndexOutOfRangeExceptionduring server authentication.Validate the current record length before either ClientHello probe, retaining the protocol-specific TLS/SSLv2 offset. Empty handshake records now throw
IOExceptionimmediately, without waiting for EOF or a sixth byte. Checking the record length rather than the buffered span also prevents trailing data from masking the malformed record. Five-byte frame recognition and application-data handling remain unchanged.Regression coverage includes direct certificates, certificate/options callbacks, sync/async authentication, both handshake implementations, fragmented reads, trailing buffered data, and a peer that keeps its transport open. Tests use TLS 1.2 to exercise managed framing rather than Apple's separate Network Framework handshake path.
Validation
Fixes: #134784
Resolves #134784
Note
This pull request was generated with GitHub Copilot.