Repository navigation
SystemNative_WaitPidExitedNoHang: ensure we don't report a child as exited in the unexpected case. - #135081
Open
tmds wants to merge 1 commit into
Open
SystemNative_WaitPidExitedNoHang: ensure we don't report a child as exited in the unexpected case.#135081tmds wants to merge 1 commit into
tmds wants to merge 1 commit into
Conversation
…xited in the unexpected case. When a user PInvokes ptrace attach on a child, .NET runtime may wrongly assume the child has exited. Contributes to dotnet#133736.
dotnet-policy-service
Bot
added
the
community-contribution
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process |
adamsitnik
approved these changes
Oct 8, 2026
adamsitnik
left a comment
adamsitnik
left a comment
Member
There was a problem hiding this comment.
It's simple and looks good, but we need a comment that explains the reasoning behind the change.
@tmds thank you!
| else | ||
| { | ||
| assert(false); | ||
| result = 0; |
Member
There was a problem hiding this comment.
@tmds could you please add a comment explaining the reasoning behind this change?
Also apologies for not reviewing this PR any time sooner. For some wonderful reason, GH decided to not notify me.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user PInvokes ptrace attach on a child, .NET runtime may wrongly assume the child has exited.
Contributes to #133736.