Repository navigation
Restore caller compile options after configuring zlib-ng - #135127
Open
ProjektMing wants to merge 1 commit into
Open
ProjektMing wants to merge 1 commit into
ProjektMing wants to merge 1 commit into
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Author
|
@dotnet-policy-service agree |
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
This was referenced Oct 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zlib-ng wrapper removes
/source-charset:utf-8from the including directory to avoid conflicting with zlib-ng's/utf-8, but does not restore it. Subsequent Mono targets can fail with C4819/C2220 when compiling UTF-8 sources on Windows with code page 936 (GBK).Save and restore the caller's directory
COMPILE_OPTIONSaroundFetchContent_MakeAvailable(fetchzlibng). zlib-ng retains its own/utf-8, while later caller targets retain their original source charset and other compile options.Also replace the em dash in the debugger protocol header comment with an ASCII
-, so the comment does not require UTF-8 decoding.Validation:
/utf-8without/source-charset:utf-8.System.IO.Compression.Native-StaticandSystem.IO.Compression.Native.Aotbuilds passed.git diff --checkpassed.Note
This change and PR description were AI-generated with OpenAI Codex.