Skip to content

[browser][coreclr] Filter emcripten source maps from runtime pack and C++ headers from app build #135216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maraf merged 1 commit into from
Oct 5, 2026
+7 −5
Merged

[browser][coreclr] Filter emcripten source maps from runtime pack and C++ headers from app build #135216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion eng/liveBuilds.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@
$(LibrariesNativeArtifactsPath)*.jar;"
IsNative="true" />

<!-- These Rollup maps are inputs to Emscripten's JS-library handling, not maps for a served module. -->
<LibrariesRuntimeFiles Condition="'$(TargetOS)' == 'browser' and '$(RuntimeFlavor)' == 'CoreCLR'"
Include="
$(CoreCLRSharedFrameworkDir)libcoreclr_static.a;
Expand All @@ -279,7 +280,11 @@
"
Exclude="$(LibrariesSharedFrameworkDir)libminipal.a;
$(LibrariesSharedFrameworkDir)libSystem.IO.Compression.Native.a;
$(LibrariesSharedFrameworkDir)libz.a"
$(LibrariesSharedFrameworkDir)libz.a;
$(LibrariesSharedFrameworkDir)libBrowserHost.js.map;
$(LibrariesSharedFrameworkDir)libSystem.Native.Browser.js.map;
$(LibrariesSharedFrameworkDir)libSystem.Native.Browser.Utils.js.map;
$(LibrariesSharedFrameworkDir)libSystem.Runtime.InteropServices.JavaScript.Native.js.map"
IsNative="true" />

<!-- Runtime tests for Helix are built without the host subset, so browser host files are excluded from the runtime tests build -->
Expand Down
4 changes: 0 additions & 4 deletions src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,14 +277,10 @@
<PlatformManifestFileEntry Include="libnativeresourcestring.a" IsNative="true" />
<PlatformManifestFileEntry Include="libBrowserHost.a" IsNative="true" />
<PlatformManifestFileEntry Include="libBrowserHost.js" IsNative="true" />
<PlatformManifestFileEntry Include="libBrowserHost.js.map" IsNative="true" />
<PlatformManifestFileEntry Include="libSystem.Native.Browser.Utils.js" IsNative="true" />
<PlatformManifestFileEntry Include="libSystem.Native.Browser.Utils.js.map" IsNative="true" />
<PlatformManifestFileEntry Include="libSystem.Native.Browser.js" IsNative="true" />
<PlatformManifestFileEntry Include="libSystem.Native.Browser.js.map" IsNative="true" />
<PlatformManifestFileEntry Include="libSystem.Native.Browser.extpost.js" IsNative="true" />
<PlatformManifestFileEntry Include="libSystem.Runtime.InteropServices.JavaScript.Native.js" IsNative="true" />
<PlatformManifestFileEntry Include="libSystem.Runtime.InteropServices.JavaScript.Native.js.map" IsNative="true" />
<!-- wasi specific -->
<PlatformManifestFileEntry Include="libWasiHost.a" IsNative="true" />
<PlatformManifestFileEntry Include="main.c" IsNative="true" />
Expand Down
1 change: 1 addition & 0 deletions src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/AssetsComputingHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ public static bool ShouldFilterCandidate(
".a" when fromRuntimePack => "extension is .a is not supported.",
".c" when fromRuntimePack => "extension is .c is not supported.",
".h" when fromRuntimePack => "extension is .h is not supported.",
".hpp" when fromRuntimePack => "extension is .hpp is not supported.",
// It is safe to filter out all XML files since we are not interested in any XML file from the list
// of ResolvedFilesToPublish to become a static web asset. Things like this include XML doc files and
// so on.
Expand Down
Loading