Skip to content

Remove support for rollForwardOnNoCandidateFx and applyPatches - #135233

Merged
elinor-fung merged 4 commits into
dotnet:mainfrom
elinor-fung:remove-legacy-roll-forward
Oct 9, 2026
Merged

elinor-fung merged 4 commits into
dotnet:mainfrom
elinor-fung:remove-legacy-roll-forward

Conversation

@elinor-fung

Copy link
Copy Markdown
Member

Remove support for the legacy rollForwardOnNoCandidateFx and applyPatches framework-resolution settings. Also simplify roll-forward precedence handling to check highest precedence first (instead of starting with lowest precedence setting and overriding with higher ones)

Resolves #131611.

Remove support for rollForwardOnNoCandidateFx and applyPatches from host configuration, resolution, diagnostics, and tests. Migrate the remaining stress-test use to DOTNET_ROLL_FORWARD and update the framework-resolution design documentation.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 7e63b140-447e-4feb-bf61-06fbcbc0ccd7
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 7e63b140-447e-4feb-bf61-06fbcbc0ccd7
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 7e63b140-447e-4feb-bf61-06fbcbc0ccd7
@elinor-fung elinor-fung added this to the 12.0.0 milestone Oct 5, 2026
@elinor-fung elinor-fung added breaking-change Issue or PR that represents a breaking API or functional change over a previous release. area-Host labels Oct 5, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 6 pipeline(s).
10 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service dotnet-policy-service Bot added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 5, 2026
@dotnet-policy-service

dotnet-policy-service Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

Comment thread docs/design/features/host-component-dependencies-resolution.md
Comment thread src/native/corehost/fxr/command_line.cpp
@elinor-fung elinor-fung removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 9, 2026
@elinor-fung
elinor-fung merged commit af174c9 into dotnet:main Oct 9, 2026
192 of 199 checks passed
@elinor-fung
elinor-fung deleted the remove-legacy-roll-forward branch October 9, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Host breaking-change Issue or PR that represents a breaking API or functional change over a previous release.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Remove support for rollForwardOnNoCandidateFx and applyPatches

2 participants