Skip to content

[wasm][JIT] Remove assertions assuming the SP arg of a fast tail call is a GT_PHYSREG #135293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lewing wants to merge 4 commits into
base: main
Choose a base branch
from
+0 −4
Open

[wasm][JIT] Remove assertions assuming the SP arg of a fast tail call is a GT_PHYSREG #135293

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
515b2bd
[wasm][JIT] Don't spill the shadow stack pointer arg for store interf…
lewing Oct 6, 2026
d1721c4
Revert "[wasm][JIT] Don't spill the shadow stack pointer arg for stor…
lewing Oct 8, 2026
2b4b2a8
Revert the morph change that avoided spilling the wasm SP arg
lewing Oct 8, 2026
8fc0f5c
Delete the SP arg asserts in WasmRegAlloc fast tail call handling
lewing Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/coreclr/jit/regallocwasm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,16 +578,12 @@ void WasmRegAlloc::CollectReferencesForCall(GenTreeCall* callNode)

// For a fast tail call, wrap the SP arg with ADD(SP, FRAME_SIZE) so codegen
// undoes the prolog's SP adjustment and the callee sees the incoming SP.
// The arg has been rewritten to GT_PHYSREG above (args are visited before the call).
if (callNode->IsFastTailCall())
{
CallArg* const spArg = callNode->gtArgs.FindWellKnownArg(WellKnownArg::WasmShadowStackPointer);
if (spArg != nullptr)
{
GenTree* const physReg = spArg->GetNode();
assert(physReg != nullptr);
assert(physReg->OperIs(GT_PHYSREG));
assert(physReg->AsPhysReg()->gtSrcReg == m_perFuncletData[m_currentFunclet]->m_spReg);
// Fast tail calls from funclets are not supported.
assert(m_currentFunclet == ROOT_FUNC_IDX);

Expand Down
Loading