Repository navigation
[release/11.0] [mono][aot] Fix recursive struct wrapper normalization - #135334
Draft
github-actions[bot] wants to merge 2 commits into
Draft
github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
github-actions
Bot
requested review from
steveisok and
vitek-karas
as code owners
October 7, 2026 09:46
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
This was referenced Oct 7, 2026
Member
|
The tests introduced by this PR are failing - #135348 . The fix for these failures should be included in this PR. |
pavelsavara
marked this pull request as draft
October 8, 2026 08:44
Remove the mutually recursive generic value types added by the original test. CoreCLR rejects that metadata while loading System.Runtime.Tests, before test discovery, which caused #135348 across unrelated CI legs. Keep the valid self-recursive shape that reproduces the Mono AOT compiler stack overflow and make its helper types private. This matches the corrected test in #135438. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #135438 to release/11.0.
/cc @pavelsavara
Customer Impact
Blazor WebAssembly AOT publishing deterministically crashes
mono-aot-crosswith a native stack overflow when a value type contains ageneric value-type field instantiated over the containing type. The customer
reproduction is tracked by #132071 and reproduces on .NET 10 and .NET 11.
Regression
This is an existing Mono AOT compiler limitation rather than a regression.
Testing
The corrected backport removes the invalid mutually recursive generic test
types from #135029 that caused #135348. It retains only the valid
self-recursive shape and makes the helper types private.
.\build.cmd -bl -os browser -subset mono+libs -c Release /p:RuntimeFlavor=MonoSystem.Tests.ValueTypeTestsrelease/11.0
mono-aot-crossaot-instances.dllcompiled successfully (14,712/14,747 methods).0xC00000FD.Risk
Low. The native change is limited to recursive gsharedvt wrapper-signature
normalization. It uses the existing non-shared fallback when a value type is
encountered again or the bounded recursion depth is reached. Acyclic value
types retain their prior normalization behavior. The corrected test avoids the
invalid cross-runtime metadata that caused the original CI regression.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.release/X.0(no-stagingsuffix).Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.
Note
This PR description was updated with GitHub Copilot.