Repository navigation
Conversation
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
jkotas
reviewed
Oct 9, 2026
|
|
||
| uint64_t getRBP() const { return *pRbp; } | ||
| void setRBP(uint64_t value, uint64_t location) { pRbp = (PTR_uintptr_t)location; } | ||
| void setRBP(uint64_t) { } |
Member
There was a problem hiding this comment.
Is the expectation that these set... methods are never called and they exist just to make things compile? Should they call abort like other similar N/A methods in this file?
Member
Author
There was a problem hiding this comment.
I have cleaned up some of them, they are called on OSX which calls setRegisterLocation.
Member
Author
|
cc @janvorli, @filipnavara, @jkotas, this refactoring reduces the patch size we apply during llvm-libunwind updates. When ready, please merge it without squashing. |
am11
force-pushed
the
feat/external/llvm-libunwind/reduce-patches
branch
from
October 9, 2026 13:27
a80b073 to
9df3e5a
Compare
Adapt the `REGDISPLAY` shims to the reduced llvm-libunwind patch: `setRegister` only carries values (IP/SP), and save locations arrive through `setRegisterLocation`. Pass pc + 1 to `stepWithDwarf` instead of patching the CFI row comparison, use the upstream `UnwindCursor` constructor, and call the templated `findUnwindSections`.
am11
force-pushed
the
feat/external/llvm-libunwind/reduce-patches
branch
from
October 9, 2026 13:32
9df3e5a to
77eb937
Compare
am11
force-pushed
the
feat/external/llvm-libunwind/reduce-patches
branch
from
October 9, 2026 13:33
77eb937 to
080ca24
Compare
Member
Author
|
Tiny improvement in size MichalStrehovsky/rt-sz#268. Flow-wise: before: after: |
This was referenced Oct 9, 2026
Member
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt the
REGDISPLAYshims to the reduced llvm-libunwind patch:setRegisteronly carries values (IP/SP), and save locations arrivethrough
setRegisterLocation. Pass pc + 1 tostepWithDwarfinstead ofpatching the CFI row comparison, use the upstream
UnwindCursorconstructor, and call the templated
findUnwindSections.