Skip to content

[release/9.0-staging] Give the nested process chain in ProcessWaitingTests depth-proportional wait budgets #135632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ViveliDuCh merged 1 commit into from
Oct 12, 2026
Merged

[release/9.0-staging] Give the nested process chain in ProcessWaitingTests depth-proportional wait budgets #135632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/libraries/System.Diagnostics.Process/tests/ProcessWaitingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,10 @@ public async Task WaitForExitAsync_AfterProcessExit_ShouldConsumeOutputDataRecei
Assert.Equal(1, linesReceived);
}

// A waiter in a nested process chain covers the start-up, work and exit of every process beneath it, so its
// budget grows with the number of processes below.
private static int ChainWaitInMS(int processesBelow) => WaitInMS * processesBelow;

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public void WaitChain()
{
Expand All @@ -552,19 +556,19 @@ public void WaitChain()
{
Process child3 = CreateProcess(() => RemoteExecutor.SuccessExitCode);
child3.Start();
Assert.True(child3.WaitForExit(WaitInMS));
Assert.True(child3.WaitForExit(ChainWaitInMS(1)));
return child3.ExitCode;
});
child2.Start();
Assert.True(child2.WaitForExit(WaitInMS));
Assert.True(child2.WaitForExit(ChainWaitInMS(2)));
return child2.ExitCode;
});
child1.Start();
Assert.True(child1.WaitForExit(WaitInMS));
Assert.True(child1.WaitForExit(ChainWaitInMS(3)));
return child1.ExitCode;
});
root.Start();
Assert.True(root.WaitForExit(WaitInMS));
Assert.True(root.WaitForExit(ChainWaitInMS(4)));
Assert.Equal(RemoteExecutor.SuccessExitCode, root.ExitCode);
}

Expand All @@ -579,7 +583,7 @@ public async Task WaitAsyncChain()
{
Process child3 = CreateProcess(() => RemoteExecutor.SuccessExitCode);
child3.Start();
using (var cts = new CancellationTokenSource(WaitInMS))
using (var cts = new CancellationTokenSource(ChainWaitInMS(1)))
{
await child3.WaitForExitAsync(cts.Token);
Assert.True(child3.HasExited);
Expand All @@ -588,7 +592,7 @@ public async Task WaitAsyncChain()
return child3.ExitCode;
});
child2.Start();
using (var cts = new CancellationTokenSource(WaitInMS))
using (var cts = new CancellationTokenSource(ChainWaitInMS(2)))
{
await child2.WaitForExitAsync(cts.Token);
Assert.True(child2.HasExited);
Expand All @@ -597,7 +601,7 @@ public async Task WaitAsyncChain()
return child2.ExitCode;
});
child1.Start();
using (var cts = new CancellationTokenSource(WaitInMS))
using (var cts = new CancellationTokenSource(ChainWaitInMS(3)))
{
await child1.WaitForExitAsync(cts.Token);
Assert.True(child1.HasExited);
Expand All @@ -606,7 +610,7 @@ public async Task WaitAsyncChain()
return child1.ExitCode;
});
root.Start();
using (var cts = new CancellationTokenSource(WaitInMS))
using (var cts = new CancellationTokenSource(ChainWaitInMS(4)))
{
await root.WaitForExitAsync(cts.Token);
Assert.True(root.HasExited);
Expand Down
Loading