Repository navigation
Reject NativeAOT closed static delegates over non-reference first parameters - #136125
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke |
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix delegate binding issue for closed static delegates
Reject NativeAOT closed static delegates over non-reference first parameters
Oct 20, 2026
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Human confirmation of CoreCLR and NativeAOT test results is needed; builds and tests were not run during this review.
No open issues 🎉
What changed in this PR
Aligns NativeAOT closed static delegate binding with CoreCLR by rejecting first parameters that cannot receive an object reference.
Changes:
- Rejects value-type, byref, pointer, and function-pointer first parameters, including null targets.
- Adds rejection coverage across overloads and generic instantiations, plus tests preserving valid reference bindings.
| File | Description |
|---|---|
| src/libraries/System.Runtime/tests/System.Runtime.Tests/System/DelegateTests.cs | Tests rejected signatures and valid reference bindings. |
| src/coreclr/nativeaot/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs | Adds the non-reference first-parameter guard. |
Review effort: Balanced
jkotas
marked this pull request as ready for review
October 20, 2026 05:44
Member
|
@MichalStrehovsky PTLA |
MichalStrehovsky
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NativeAOT accepts closed static delegates over non-reference first parameters, passing an object reference where the method expects a value. CoreCLR rejects these bindings.
ArgumentException;throwOnBindFailure: falsereturnsnull.