Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The server guidance incorrectly implies that selecting Kerberos alone prevents NTLM on Unix with default credentials.
1 open issue
What changed in this PR
Adds XML documentation to System.Net.Security describing NTLM’s legacy role without changing runtime behavior.
Changes:
- Recommends NTLM only for compatibility with existing systems.
- Explains Negotiate fallback and provides guidance for avoiding NTLM.
Builds and tests were not run; verification used source inspection.
| File | Description |
|---|---|
| src/libraries/System.Net.Security/src/System/Net/Security/NegotiateAuthenticationServerOptions.cs | Adds server authentication package guidance. |
| src/libraries/System.Net.Security/src/System/Net/Security/NegotiateAuthenticationClientOptions.cs | Adds client authentication package guidance. |
| src/libraries/System.Net.Security/src/System/Net/Security/NegotiateAuthentication.cs | Documents NTLM’s legacy status and alternatives. |
Review effort: Balanced
Comment on lines
+33
to
+34
| /// can fall back to NTLM. To prevent NTLM, request Kerberos explicitly when supported | ||
| /// or use another modern authentication protocol. |
Member
|
This will not update the existing documentation online AFAIK, this will need porting to dotnet/dotnet-api-docs repo. |
5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This pull request description was generated with GitHub Copilot.