Skip to content

Only check inexact match when no exact match is found. - #39961

Closed
yyjdelete wants to merge 1 commit into
dotnet:masterfrom
yyjdelete:master
Closed

Only check inexact match when no exact match is found.#39961
yyjdelete wants to merge 1 commit into
dotnet:masterfrom
yyjdelete:master

Conversation

@yyjdelete

@yyjdelete yyjdelete commented Jul 27, 2020

Copy link
Copy Markdown

Fix #39620

Avoid the exact match result be overwrite by later inexact ones.
This may not happen due to limited callsites, just make the code more clear.

@Dotnet-GitSync-Bot

Copy link
Copy Markdown
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@dnfadmin

dnfadmin commented Jul 27, 2020

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@ghost

ghost commented Jul 27, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

@Wraith2

Wraith2 commented Jul 27, 2020

Copy link
Copy Markdown
Contributor

Tests?

@yyjdelete

yyjdelete commented Jul 28, 2020

Copy link
Copy Markdown
Author

Infact, I don't know how and where to create an test for this internal api. And maybe it's not a problem due to it's internal and there is no dupe tables with different case actually used by public apis.

https://github.com/dotnet/runtime/search?q=filename%3AMetaData.xml&unscoped_q=filename%3AMetaData.xml

@yyjdelete yyjdelete closed this Jul 28, 2020

@David-Engel David-Engel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't close this PR just because you aren't adding tests. The bug is valid and benefits from being fixed, even though it doesn't surface with the existing *.SqlMetaData.xml embedded resources.

@yyjdelete yyjdelete reopened this Jul 29, 2020
@danmoseley

Copy link
Copy Markdown
Contributor

@cheenamalhotra this PR is pretty old now -- what's the next step?

@cheenamalhotra

Copy link
Copy Markdown
Member

Since we don't have System.Data.SqlClient anymore, it can be closed.
The fix was ported over to Microsoft.Data.SqlClient - dotnet/SqlClient#668

@ghost ghost locked as resolved and limited conversation to collaborators Jan 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strange logic in System.Data.ProviderBase.DbMetaDataFactory.FindMetaDataCollectionRow()

8 participants