Skip to content

Disable tests on Debug CoreClr that are already disabled on Checked CoreClr#64891

Merged
danmoseley merged 4 commits into
dotnet:mainfrom
danmoseley:tilda.release
Feb 12, 2022
Merged

Disable tests on Debug CoreClr that are already disabled on Checked CoreClr#64891
danmoseley merged 4 commits into
dotnet:mainfrom
danmoseley:tilda.release

Conversation

@danmoseley

@danmoseley danmoseley commented Feb 7, 2022

Copy link
Copy Markdown
Contributor

A number of tests are disabled for Checked runtime. I assume these intended to also disable for Debug runtime, which is even slower.

Also increased timeout when not on a release runtime for some Process tests that are timing out on a debug runtime.

@ghost

ghost commented Feb 7, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

A number of tests are disabled for Checked runtime. I assume these intended to also disable for Debug runtime, which is even slower.

Author: danmoseley
Assignees: -
Labels:

area-Meta

Milestone: -

Comment thread src/libraries/System.Diagnostics.Process/tests/ProcessTestBase.cs Outdated
@jkotas

jkotas commented Feb 7, 2022

Copy link
Copy Markdown
Member

a debug runtime.

The debug runtime is super slow. We never run tests on it.

If we want to be hardening the tests for super slow modes of execution (GCStress is another example of that), we should introduce a concept timeout multiplier and apply it to all hardcoded timeouts.

yield return (@"\Aaaa\w+zzz\Z", "aaaasdfajsdlfjzzz", RegexOptions.IgnoreCase, 0, 17, true, "aaaasdfajsdlfjzzz");
yield return (@"\Aaaaaa\w+zzz\Z", "aaaa", RegexOptions.IgnoreCase, 0, 4, false, string.Empty);
if (!RegexHelpers.IsNonBacktracking(engine))
//if (!RegexHelpers.IsNonBacktracking(engine))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional change? Looks like it is causing the test failures.

Comment thread src/libraries/System.Text.RegularExpressions/tests/Regex.Match.Tests.cs Outdated
@danmoseley

Copy link
Copy Markdown
Contributor Author

Downloading 'https://dotnet.microsoft.com/download/dotnet/scripts/v1/dotnet-install.sh'
2022-02-11T16:35:37.2873610Z curl: (6) Couldn't resolve host 'dotnet.microsoft.com'
2022-02-11T16:35:37.2883817Z Curl failed; dumping some information about dotnet.microsoft.com for later investigation
2022-02-11T16:35:57.3091275Z 140549514965440:error:2008F002:BIO routines:BIO_lookup_ex:system lib:../crypto/bio/b_addr.c:704:Temporary failure in name resolution
2022-02-11T16:35:57.3093479Z connect:errno=11
2022-02-11T16:35:57.3310648Z ##[error]Bash exited with code '1'.

@dotnet/dnceng do you know who might want the tracing info above?

@danmoseley

Copy link
Copy Markdown
Contributor Author

Oh never mind - probably this is from curl itself

@danmoseley

Copy link
Copy Markdown
Contributor Author

Build failure is not connecting to microsoft.com. Happened twice -- negligible risk merging given all other builds passed

@danmoseley
danmoseley merged commit 348e06c into dotnet:main Feb 12, 2022
@danmoseley
danmoseley deleted the tilda.release branch February 12, 2022 18:32
@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants