Skip to content

Don't use _ASSERTE in runtime tests #68299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lambdageek merged 5 commits into from
Apr 21, 2022
Merged

Don't use _ASSERTE in runtime tests #68299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e3c7aac
link coreclrpal static library into tests that use pal.h
lambdageek Apr 20, 2022
f4ac3e2
don't link coreclrpal static lib into the profiler tests
lambdageek Apr 21, 2022
de6aaa7
Don't use _ASSERTE in runtime tests
lambdageek Apr 21, 2022
2454635
second arg of add_subdirectory is a binary dir
lambdageek Apr 21, 2022
a12a256
use an absolute path for binary_dir
lambdageek Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ include(${CLR_ENG_NATIVE_DIR}/configurecompiler.cmake)
include_directories("${CLR_SRC_NATIVE_DIR}")

# Add this subdir. We install the headers for the jit.
add_subdirectory(../coreclr/pal/prebuilt/inc ../coreclr/pal/prebuilt/inc)
add_subdirectory(${CLR_REPO_ROOT_DIR}/src/coreclr/pal/prebuilt/inc ${CLR_ARTIFACTS_OBJ_DIR}/coreclr/pal/prebuilt/inc)

set(INC_PLATFORM_DIR ${CMAKE_CURRENT_SOURCE_DIR}/Common/Platform)
if (CLR_CMAKE_TARGET_WIN32)
Expand Down
3 changes: 2 additions & 1 deletion src/tests/profiler/native/eventpipeprofiler/eventpipewritingprofiler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

#pragma once

#include <assert.h>
#include "../profiler.h"

class EventPipeWritingProfiler : public Profiler
Expand Down Expand Up @@ -37,7 +38,7 @@ class EventPipeWritingProfiler : public Profiler
template<typename T>
static void WriteToBuffer(BYTE *pBuffer, size_t bufferLength, size_t *pOffset, T value)
{
_ASSERTE(bufferLength >= (*pOffset + sizeof(T)));
assert(bufferLength >= (*pOffset + sizeof(T)));

*(T*)(pBuffer + *pOffset) = value;
*pOffset += sizeof(T);
Expand Down