Repository navigation
Consolidate NCL stress testing infrastructure - #700
eiriktsarpalis merged 30 commits into
Conversation
eiriktsarpalis
added
area-Infrastructure-libraries
tenet-reliability
|
/azp list |
|
/azp run runtime-libraries stress-http-windows |
|
/azp run runtime-libraries stress-http-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries stress-http-windows |
|
/azp run runtime-libraries stress-http-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries stress-http-windows |
|
/azp run runtime-libraries stress-http-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries stress-http-windows |
|
/azp run runtime-libraries stress-http-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries stress-ssl-windows |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run runtime-libraries stress-ssl-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries stress-ssl-windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries stress-http-linux |
|
/azp run runtime-libraries stress-http-windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
PR is ready for review |
I'm curious...what is the advantage of having multiple jobs in a single pipeline? Is it just the convenience of having a single "azp run" command? If both Linux and Windows jobs are in the same pipeline then will it run slower since the jobs are serialized? |
Jobs are run in parallel unless they depend on eachother. For example: https://dev.azure.com/dnceng/public/_build/results?buildId=453772&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb |
I've found per-os separation to be a hassle, in practice. If a stress run is required, then you generally want to trigger it for all available operating systems, so you end up having to type multiple /azp commands. Merging is also more in line with how our CI pipelines are structured. |
davidsh
left a comment
davidsh
left a comment
There was a problem hiding this comment.
Left a few comments, but otherwise LGTM.
Thank you for improving our overall usage of docker and related tools. :)
| [switch][Alias('w')]$buildWindowsContainers | ||
| ) | ||
|
|
||
| $REPO_ROOT_DIR=$(git -C "$PSScriptRoot" rev-parse --show-toplevel) |
There was a problem hiding this comment.
Should we remove the git dependency here at some point?
There was a problem hiding this comment.
And replace with a relative path? Do we expect this to run outside of a repo?
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
Thanks a lot, this is great 👍
|
/azp run runtime-libraries stress-ssl |
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
This PR:
/eng/dockerfolder.