Skip to content

MonoAOTCompiler.cs: fix regression in caching, which breaks incremental#73427

Merged
radical merged 1 commit into
dotnet:mainfrom
radical:fix-aot-regression
Aug 5, 2022
Merged

MonoAOTCompiler.cs: fix regression in caching, which breaks incremental#73427
radical merged 1 commit into
dotnet:mainfrom
radical:fix-aot-regression

Conversation

@radical

@radical radical commented Aug 5, 2022

Copy link
Copy Markdown
Member

.. builds.

#72394 disabled the cache always,
even when it was intended to be used. This reverses that change.

This shows up as a Wasm.Build.Tests failure:

Wasm.Build.NativeRebuild.Tests.SimpleSourceChangeRebuildTest.SimpleStringChangeInSource(buildArgs: BuildArgs { ProjectName = placeholder, Config = Release, AOT = True, ProjectFileContents = placeholder, ExtraBuildArgs =  }, nativeRelink: False, invariant: False, host: Chrome, id: "kfqswgdd.hbi") [FAIL]
      CompareStat failed:
      [Expected unchanged file: System.Private.CoreLib.dll.bc]
         old: FileStat { Exists = True, LastWriteTimeUtc = 8/4/2022 9:01:26 PM, Length = 16570448, FullPath = /datadisks/disk1/work/AEEC0971/w/AF8A095A/e/kfqswgdd.hbi/obj/Release/net7.0/browser-wasm/wasm/for-publish/System.Private.CoreLib.dll.bc }
         new: FileStat { Exists = True, LastWriteTimeUtc = 8/4/2022 9:02:39 PM, Length = 16570448, FullPath = /datadisks/disk1/work/AEEC0971/w/AF8A095A/e/kfqswgdd.hbi/obj/Release/net7.0/browser-wasm/wasm/for-publish/System.Private.CoreLib.dll.bc }

Fixes #73419

.. builds.

dotnet#72394 disabled the cache always,
even when it was intended to be used. This reverses that change.

Fixes dotnet#73419
@radical

radical commented Aug 5, 2022

Copy link
Copy Markdown
Member Author

/azp run runtime-extra-platforms

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

radical commented Aug 5, 2022

Copy link
Copy Markdown
Member Author

@steveisok @mdh1418 What was the problem being fixed with this change?

@radical

radical commented Aug 5, 2022

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mdh1418

mdh1418 commented Aug 5, 2022

Copy link
Copy Markdown
Member

@steveisok @mdh1418 What was the problem being fixed with this change?

I don't recall there being a problem per se. I think there was a decision to disable caching for the NetTraceToMibc process, but missed this among the changes.

@radical

radical commented Aug 5, 2022

Copy link
Copy Markdown
Member Author

Debugger tests failure is #66024 .
@mdh1418 @steveisok Are the mobile ones known to fail?

@radical

radical commented Aug 5, 2022

Copy link
Copy Markdown
Member Author

Please merge if the failures look unrelated.

@radical

radical commented Aug 5, 2022

Copy link
Copy Markdown
Member Author

The other failures are #73343, #73453 . And some others are runtime tests with interpreter etc, but not related to this PR at all, AFAICS.

I'm going to merge this now, and unblock the CI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wasm] WBT test failure - SimpleSourceChangeRebuildTest.SimpleStringChangeInSource

2 participants