Draft fix for a series of multiplications (#75413)#75414
Conversation
ghost
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsCreated a draft fix for the series of multiplications.
|
|
|
||
| mul->gtOp1 = lsOpChOp1; | ||
| mul->gtOp2 = lsOpChOp2; | ||
| mul->gtOp2->AsIntConCommon()->SetIntegralValue(root_val + child_val); |
There was a problem hiding this comment.
Should you check if root_val+child_val can overflow here?
There was a problem hiding this comment.
It seems there must be some checks, but I can't think of any right now.
The tricky part is that multiplications become shifts and the value transforms from a number to a count of shifts. I don't know if it actually possible to make
X >> 2,147,483,647
There is another problem with the PR which made me mark it as a draft. The problem is that the PR causes 9 regressions (along with some improvements) I need some help in addressing them.
It would be very nice if someone from the team became a reviewer.
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
locked as resolved and limited conversation to collaborators
3 participants
Created a draft fix for the series of multiplications.