Skip to content

#76596 update icu version for norwegian culture#77003

Merged
mkhamoyan merged 5 commits into
mainfrom
76596_update_icu_version
Oct 17, 2022
Merged

#76596 update icu version for norwegian culture#77003
mkhamoyan merged 5 commits into
mainfrom
76596_update_icu_version

Conversation

@mkhamoyan

Copy link
Copy Markdown
Contributor

Updating icu version after adding "nb-NO" culture in icu filters dotnet/icu#271
Fix #76596

@ghost ghost assigned mkhamoyan Oct 13, 2022
@ghost

ghost commented Oct 13, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Updating icu version after adding "nb-NO" culture in icu filters dotnet/icu#271
Fix #76596

Author: mkhamoyan
Assignees: -
Labels:

area-System.Globalization

Milestone: -

@mkhamoyan

Copy link
Copy Markdown
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@steveisok

Copy link
Copy Markdown
Member

@mkhamoyan is there a test in runtime which validates the culture is there?

@mkhamoyan

Copy link
Copy Markdown
Contributor Author

@mkhamoyan is there a test in runtime which validates the culture is there?

No, I modified and checked locally only. Will add test case checking that.

@mkhamoyan

Copy link
Copy Markdown
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

[InlineData("nb-NO")]
public void ContainsCulture(string culture)
{
var cultures = CultureInfo.GetCultures(CultureTypes.AllCultures).ToList();

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need ToList() here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it.

@tarekgh tarekgh added the os-ios Apple iOS label Oct 13, 2022
@ghost

ghost commented Oct 13, 2022

Copy link
Copy Markdown

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

Updating icu version after adding "nb-NO" culture in icu filters dotnet/icu#271
Fix #76596

Author: mkhamoyan
Assignees: mkhamoyan
Labels:

area-System.Globalization, os-ios

Milestone: -

@mkhamoyan

Copy link
Copy Markdown
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan

Copy link
Copy Markdown
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan

Copy link
Copy Markdown
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@lewing

lewing commented Oct 15, 2022

Copy link
Copy Markdown
Member

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan

Copy link
Copy Markdown
Contributor Author

Failures are unrelated to the changes.

@mkhamoyan mkhamoyan merged commit 4574ccb into main Oct 17, 2022
@akoeplinger akoeplinger deleted the 76596_update_icu_version branch October 27, 2022 13:13
@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A DateTime.ToString with CultureInfo("nb-NO") gives the wrong datetime string output on iOS

4 participants