Skip to content

Add [DebuggerStepThrough] to MulticastDelegate constructors.#77132

Merged
hoyosjs merged 1 commit into
dotnet:mainfrom
chuckries:multicast_delegate_step_through
Oct 20, 2022
Merged

Add [DebuggerStepThrough] to MulticastDelegate constructors.#77132
hoyosjs merged 1 commit into
dotnet:mainfrom
chuckries:multicast_delegate_step_through

Conversation

@chuckries

Copy link
Copy Markdown
Contributor

Adding [DebuggerStepThrough] to these constructors allows debuggers to avoid stepping into them and stopping regardless of Just My Code settings. This is desirable for debuggers as there is little benefit to stopping in these constructors as they are primarily infrastructure inserted by the compiler.

Adding [DebuggerStepThrough] to these constructors allows debuggers to
avoid stepping into them and stopping regardless of Just My Code
settings. This is desirable for debuggers as there is little benefit to
stopping in these constructors as they are primarily infrastructure
inserted by the compiler.
@ghost

ghost commented Oct 17, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 17, 2022
@chuckries

Copy link
Copy Markdown
Contributor Author

fixes #77131

@ghost

ghost commented Oct 17, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Adding [DebuggerStepThrough] to these constructors allows debuggers to avoid stepping into them and stopping regardless of Just My Code settings. This is desirable for debuggers as there is little benefit to stopping in these constructors as they are primarily infrastructure inserted by the compiler.

Author: chuckries
Assignees: -
Labels:

area-Diagnostics-coreclr, community-contribution

Milestone: -

@tommcdon

Copy link
Copy Markdown
Member

LGTM - adding @noahfalk @hoyosjs for additional review

@tommcdon

Copy link
Copy Markdown
Member

Adding @thaystg @lambdageek for awareness and in case something similar should be done for mono

@tommcdon tommcdon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've added a few other folks for additional review.

@hoyosjs

hoyosjs commented Oct 20, 2022

Copy link
Copy Markdown
Member

All issues are known (cc: @missymessa @AlitzelMendez @ulisesh @markwilkie, since the check tab is still red...), so merging this one.

@hoyosjs hoyosjs merged commit 6e51009 into dotnet:main Oct 20, 2022
@ulisesh

ulisesh commented Oct 20, 2022

Copy link
Copy Markdown
Contributor

Thanks for the heads up @hoyosjs, the check is red by design. We are still deciding if we want to make the check green if all failures are known. Something interesting about the generated check is that the failures are shown as infrastructure failures but they look like test issues to me. I'll investigate what happened

@ghost ghost locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Diagnostics-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants