Skip to content

Remove more swprintf_s uses#77228

Merged
AaronRobinsonMSFT merged 5 commits into
dotnet:mainfrom
AaronRobinsonMSFT:remove_more_printf
Oct 20, 2022
Merged

Remove more swprintf_s uses#77228
AaronRobinsonMSFT merged 5 commits into
dotnet:mainfrom
AaronRobinsonMSFT:remove_more_printf

Conversation

@AaronRobinsonMSFT

@AaronRobinsonMSFT AaronRobinsonMSFT commented Oct 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

This removes the last uses of swprintf_s and thus can be removed from the PAL.

@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 8.0.0 milestone Oct 19, 2022
jakobbotsch
jakobbotsch reviewed Oct 19, 2022
View reviewed changes
Comment thread src/coreclr/jit/fgdiagnostic.cpp Outdated
janvorli
janvorli reviewed Oct 19, 2022
View reviewed changes
Comment thread src/coreclr/pal/src/misc/fmtmessage.cpp Outdated
Comment thread src/coreclr/jit/fgdiagnostic.cpp Outdated
@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as ready for review October 19, 2022 22:20
@build-analysis build-analysis Bot mentioned this pull request Oct 20, 2022
Closed
janvorli
janvorli approved these changes Oct 20, 2022
View reviewed changes

@janvorli janvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 35f4967 into dotnet:main Oct 20, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the remove_more_printf branch October 20, 2022 14:48
@am11

am11 commented Oct 20, 2022

Copy link
Copy Markdown
Member

This PR has broken mono build

https://dev.azure.com/dnceng-public/public/_build/results?buildId=58398&view=logs&jobId=09abd379-6e00-520a-dbc1-1ced895342b5&j=09abd379-6e00-520a-dbc1-1ced895342b5&t=e4972926-a910-54c6-e301-cbf7699adb4c

  [ 94%] Building CXX object dlls/mscordbi/utilcode/CMakeFiles/utilcode_obj.dir/opinfo.cpp.o
  [ 94%] Building CXX object dlls/mscordbi/utilcode/CMakeFiles/utilcode_obj.dir/corimage.cpp.o
  /Users/runner/work/1/s/src/mono/dlls/dbgshim/dbgshim.cpp:64:5: error: use of undeclared identifier 'swprintf_s'
      swprintf_s(w_android_run_adb_command, 2048, W("%ws %ws"), w_android_adb_path, w_command_to_execute);
      ^

@elinor-fung elinor-fung mentioned this pull request Oct 20, 2022
Closed
@AaronRobinsonMSFT

AaronRobinsonMSFT commented Oct 20, 2022

Copy link
Copy Markdown
Member Author

This PR has broken mono build

Fix is #77284

@ghost ghost locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

@janvorli janvorli janvorli approved these changes

@BruceForstall BruceForstall Awaiting requested review from BruceForstall

+1 more reviewer

@SingleAccretion SingleAccretion SingleAccretion left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@AaronRobinsonMSFT AaronRobinsonMSFT

Labels

area-VM-coreclr

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@AaronRobinsonMSFT @am11 @jakobbotsch @janvorli @SingleAccretion