Skip to content

Set DNER for all local fields#77341

Merged
EgorBo merged 1 commit into
dotnet:mainfrom
SingleAccretion:Make-Stress-A-Bit-Less-Red
Oct 22, 2022
Merged

Set DNER for all local fields#77341
EgorBo merged 1 commit into
dotnet:mainfrom
SingleAccretion:Make-Stress-A-Bit-Less-Red

Conversation

@SingleAccretion

@SingleAccretion SingleAccretion commented Oct 22, 2022

Copy link
Copy Markdown
Contributor

I noticed our stress was deeply red, this should fix one of the offenders at least.

Fixes #77300.

No diffs.

Not just the promoted ones.
@ghost ghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Oct 22, 2022
@ghost

ghost commented Oct 22, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

I noticed our stress was deeply red, this should fix one of the offenders at least.

Fixes #77300.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@SingleAccretion SingleAccretion marked this pull request as ready for review October 22, 2022 16:54
@SingleAccretion

Copy link
Copy Markdown
Contributor Author

@dotnet/jit-contrib

@EgorBo

EgorBo commented Oct 22, 2022

Copy link
Copy Markdown
Member

Nice! Any idea what broke it? 🙂

@SingleAccretion

SingleAccretion commented Oct 22, 2022

Copy link
Copy Markdown
Contributor Author

Likely exposed by #77102.

@EgorBo EgorBo merged commit 4e85471 into dotnet:main Oct 22, 2022
@SingleAccretion SingleAccretion deleted the Make-Stress-A-Bit-Less-Red branch October 24, 2022 17:08
kunalspathak added a commit to kunalspathak/runtime that referenced this pull request Oct 30, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure readytorun\\coreroot_determinism\\coreroot_determinism\\coreroot_determinism.cmd

2 participants